Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp756602ybl; Wed, 4 Dec 2019 10:19:54 -0800 (PST) X-Google-Smtp-Source: APXvYqy+MSnf2IuweHQU2zUr32PjW1IoyGY6N4nsPVzFZO6uCiG+Tpn7wwi8UbmmWYr8k9gzplxn X-Received: by 2002:aca:d6d2:: with SMTP id n201mr3969261oig.112.1575483594266; Wed, 04 Dec 2019 10:19:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575483594; cv=none; d=google.com; s=arc-20160816; b=Gh2P3SZ9ldfOZFJ38X4WFjXSQExN7+OuptVS8RGgUxp7h4escVQgGAXW0l7jsVnGYT +P+ab4nmNt9sFluKe/mJjo3m2ruwIaTgdRwyqyUOHSv8Cwem5fqvAM4uq36jyQPK0qHZ JJAT/h3dHiASX1W9W8SI1+Y3I+JBxY6Q8JqepWlcY8vkVSfBNSd/F/+aMITn0p/vXYjE y2Q/saqFsIz2LDyFi+gTc75WVHGaWsH8nimuE+hC1qQwPQ2MjQt2jPwxRLlDzmSMOXEu K2G4Eqi4dams11Ks1BqGXuwSgYU/tCYe90arIMnleGcTocbcGBILk51Dg+os0yvZhg3o qv+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ametK6ZTDNnJzjXTXXoTpHFpZIY34/+2nzaY6+p/G+Q=; b=mfK8rAV198/8xHtEOFhRCWQg/E9TUffdxVH8trHOuR8LEJyWCQqkyZVxVF+QVaWtFp rVN/qjY3U2eyLBFeQhzISS7QsS+n8UYSQOyU1Udxe9+IbCOcyPW/jfLmohn0mcem4udr rDwk0OV0I2lqeQ7pZCSZWujdudh0G7qaejt4RhEcTEPHOTFJ/UUwSHZAUPhTr+QtXJX/ dAfvP8OhslcBSOmJwFFe7lbXXLP6XfIe7nu/F4LvqvQjHTFnIu2+cf4+zIeg20CYkJ0j x/N4srfYHA4SxUcjL+pc3uResrZaBfU6S7oPyuCAtFQ1waFtG0hGKoYVIbcrgBGFBgnU 1YYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RbKZk8Rm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 89si3482854otn.277.2019.12.04.10.19.41; Wed, 04 Dec 2019 10:19:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RbKZk8Rm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731514AbfLDSLq (ORCPT + 99 others); Wed, 4 Dec 2019 13:11:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:40058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731490AbfLDSLo (ORCPT ); Wed, 4 Dec 2019 13:11:44 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 54F2520675; Wed, 4 Dec 2019 18:11:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575483103; bh=wkEHc2vi4TFrHFuiD99EPJJTFGKpOOfZk8ZzaLYIR4g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RbKZk8RmV0tHzaMqE6ns+lWCBVEC9mHPAachGJwMgar9xi9qHMDudJ6QQOBAne7cf rxBwOgElKfGbNNiuKZquc0KfkIISDFsBRUsWFBFCV+wJRbG1SCUWbmUWrQqVUJMlHG hrtpUG8CugljXlpFFKWOHrciHahsgwXLuJQY3YpA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nikolay Borisov , Josef Bacik , David Sterba , Sasha Levin Subject: [PATCH 4.9 036/125] btrfs: only track ref_heads in delayed_ref_updates Date: Wed, 4 Dec 2019 18:55:41 +0100 Message-Id: <20191204175321.176847148@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175308.377746305@linuxfoundation.org> References: <20191204175308.377746305@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Josef Bacik [ Upstream commit 158ffa364bf723fa1ef128060646d23dc3942994 ] We use this number to figure out how many delayed refs to run, but __btrfs_run_delayed_refs really only checks every time we need a new delayed ref head, so we always run at least one ref head completely no matter what the number of items on it. Fix the accounting to only be adjusted when we add/remove a ref head. In addition to using this number to limit the number of delayed refs run, a future patch is also going to use it to calculate the amount of space required for delayed refs space reservation. Reviewed-by: Nikolay Borisov Signed-off-by: Josef Bacik Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- fs/btrfs/delayed-ref.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/btrfs/delayed-ref.c b/fs/btrfs/delayed-ref.c index 8d93854a4b4f3..74c17db752014 100644 --- a/fs/btrfs/delayed-ref.c +++ b/fs/btrfs/delayed-ref.c @@ -193,8 +193,6 @@ static inline void drop_delayed_ref(struct btrfs_trans_handle *trans, ref->in_tree = 0; btrfs_put_delayed_ref(ref); atomic_dec(&delayed_refs->num_entries); - if (trans->delayed_ref_updates) - trans->delayed_ref_updates--; } static bool merge_ref(struct btrfs_trans_handle *trans, @@ -445,7 +443,6 @@ add_delayed_ref_tail_merge(struct btrfs_trans_handle *trans, add_tail: list_add_tail(&ref->list, &href->ref_list); atomic_inc(&root->num_entries); - trans->delayed_ref_updates++; spin_unlock(&href->lock); return ret; } -- 2.20.1