Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp758031ybl; Wed, 4 Dec 2019 10:21:18 -0800 (PST) X-Google-Smtp-Source: APXvYqy06smS2J0DcLLf08CXN/a61rxullvO0BjslkaB6qibfq6vuDkDZ4f3BCdDT1fxGbPG5cQp X-Received: by 2002:aca:c1c2:: with SMTP id r185mr3844483oif.125.1575483678810; Wed, 04 Dec 2019 10:21:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575483678; cv=none; d=google.com; s=arc-20160816; b=eWgw/M029SvzdbRC07adS4F137v9ZNBMbIfz6YYKXrVC0FsdjygkvnKZeaY4QTOGcl spEGSh37wRvOTRsbmqe98D3meSwQ67Z60hYdTrfprDiuba52KfnSUePDyGWXB+G/jUro KTSvvJtFxZ2/6uBMMLlbf38mSkk+MYVE/EEw5bvWg8lkoeclUP3AZBnEM/WoFMw6BCWu Qsavqv5GKYg95hqSA059c9JreAVAc5Ds+YMzpBxaOZ0Yb5p2I9LbTIlujN27/Iguby5S p93YERJIGYo+Ekmz+9dbsI1PpDATWg09HzQPXI89pyjcSOmYLtddACYW4/oNaXtjccQv D+SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=yHX9M9GA4TAIhYuhXnpmjZ20TZ1rO3VaqCe63/cpBgw=; b=jpHMm796VGAZw/vu01U9pM5dHT3NYdZwxFpBZ2GDKlesy7xeN1VjCFmpGIp0nIGUp0 AV9Vlu90ip6JVnAdz5I4eXHCepitH4juaCXuRMs+6WfhELhwPOg1Ri8iUMIXBXoDWgh1 TJT2McWw0QA3D2dRQgh9xjW8uH7bM7x4DWaAcx8KktSAnt0ML9ivXLXGxMURtCWMjL3g kcCzcURosasN6R9sudc6l8z7/mlfhkWQgIHXQVCSd0FWHxJ+iQED3dlnv9kYAs0YFIlL a0/ZpRvN8FuKhhZwT8oJkmSqgeJEbiopuFHt1v4FgsnbUf4bb4/k98zUgnCnCvGjWB42 9DjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QublcnU4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k23si3830819otp.181.2019.12.04.10.21.06; Wed, 04 Dec 2019 10:21:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QublcnU4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730687AbfLDSUF (ORCPT + 99 others); Wed, 4 Dec 2019 13:20:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:33612 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730941AbfLDSIx (ORCPT ); Wed, 4 Dec 2019 13:08:53 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E18120674; Wed, 4 Dec 2019 18:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482933; bh=XNoYKvz5jYsa7e1+etOwz3MmWT1KcokIq3KV72exAlg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QublcnU4b/6ZCijHaO6HmT0E7VGmf8z95LHCO2fCG5XxflXfMtnH/wn1E/SSqqHD3 oy7QCjzXtgpTrH7F7dgiqyM8PmLgrkZGUp7lE02KiyLhFIPZAsyLgu32pM89bI4R4A twIBEsswX7siAyrUkugqYP5/s28Zvta46Re4b92w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bert Kenward , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 139/209] sfc: initialise found bitmap in efx_ef10_mtd_probe Date: Wed, 4 Dec 2019 18:55:51 +0100 Message-Id: <20191204175332.872633447@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175321.609072813@linuxfoundation.org> References: <20191204175321.609072813@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bert Kenward [ Upstream commit c65285428b6e7797f1bb063f33b0ae7e93397b7b ] The bitmap of found partitions in efx_ef10_mtd_probe was not initialised, causing partitions to be suppressed based off whatever value was in the bitmap at the start. Fixes: 3366463513f5 ("sfc: suppress duplicate nvmem partition types in efx_ef10_mtd_probe") Signed-off-by: Bert Kenward Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/sfc/ef10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c index cc3be94d05622..2d92a9fe4606c 100644 --- a/drivers/net/ethernet/sfc/ef10.c +++ b/drivers/net/ethernet/sfc/ef10.c @@ -5918,7 +5918,7 @@ static int efx_ef10_mtd_probe_partition(struct efx_nic *efx, static int efx_ef10_mtd_probe(struct efx_nic *efx) { MCDI_DECLARE_BUF(outbuf, MC_CMD_NVRAM_PARTITIONS_OUT_LENMAX); - DECLARE_BITMAP(found, EF10_NVRAM_PARTITION_COUNT); + DECLARE_BITMAP(found, EF10_NVRAM_PARTITION_COUNT) = { 0 }; struct efx_mcdi_mtd_partition *parts; size_t outlen, n_parts_total, i, n_parts; unsigned int type; -- 2.20.1