Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp764032ybl; Wed, 4 Dec 2019 10:27:23 -0800 (PST) X-Google-Smtp-Source: APXvYqxjbQSyiOYNYM61NYwAr+5Y1mzRvhmlZ5pYR3RLRmozTJGZgYnNVmYUzh9IcA4NJo9f7c5X X-Received: by 2002:a9d:7d9a:: with SMTP id j26mr3800851otn.283.1575484043911; Wed, 04 Dec 2019 10:27:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575484043; cv=none; d=google.com; s=arc-20160816; b=or6+r2//udkHIsf+5A7w7RuvS6WmABq1o4pooswNQcEjPd2hOzW0sZNSJ+1a0a2paV cckhIV3DAGGzqCFqsd3K1LihADtqqVzwDixWeudGhrtLuSgZHymPdtpulkwnZpkBOSfg o84YMjEsqj7/VvcIcfanYmOQYExd2R4q1mpmjboxwgMkKGO+zmWg0Q0ylWHucI32fwcL p1SuH5FkOXBFVTD4BnAmvBuDQk27UvMNIy//0U4h/P1NGegPrlxYDn2947rNNkjEyuTs Ioc80lw9+Kz0xZeCrhv2/ZSyHIOl9lxxGfrl5wYSM00BR3rQOGwCilngQLaWTsIWfszz +9Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PYX2UeIlU3m7EL5vM5jXnKN/6SBkapFf1SU1A5B+4BM=; b=x9jUn8QkZzo2/DLpcEYMAotMGpEjjVL9oXEM3PoKgaF43GlU4SHTjjrT21w266hlU2 U6x/AmqZOzJOKq9A/7pZpbGad2/cGyooeTAdqVnb5wnR6vR+KThNzkJ3dpLcBh5YXUGJ zQZMAs+JMXAD6WYZT8N7ltjw41IY4ko6/C9kDzDDAZNyb3iPHAGtulaU9sR2jcDFs8Ow J7xMXN2sUIEJijOuSM0xHZprOgSqqJ+AiGhvoZNgFTLU0UliB5JoZ9yAhPTLo6nn4HkA s6hEdEWcCEkc1p6iHQVc3tcQKtHYoDVBl9kLyD/8f1te8Cf+6lAB4EPWnKcsaD7UZSmf PEqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=J921b+PQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n9si3687383oie.261.2019.12.04.10.27.12; Wed, 04 Dec 2019 10:27:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=J921b+PQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729846AbfLDS0O (ORCPT + 99 others); Wed, 4 Dec 2019 13:26:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:37616 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728784AbfLDR77 (ORCPT ); Wed, 4 Dec 2019 12:59:59 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0DF1C20675; Wed, 4 Dec 2019 17:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482399; bh=884x5ShrfFbzeDpMRlDucGW/FgT0RTwPFiSeSuVL/Xw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J921b+PQKApR+yg1dnCF7oYfJkbOrpHmMI6Wj8XG0RbVm9vQBSoyDqwkD1PENMyHc 882CelFqFNvwsm1o9JZ/Qo95Y8RtyyN6VduTTh8/cR5/yyWBKcA/yb+ZX8JSly+xeR ke3AK6BJJqgr0DuU/TKshSQ3belzEmMlXtc0670M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andy Shevchenko , "David S. Miller" , Sasha Levin Subject: [PATCH 4.4 71/92] net: dev: Use unsigned integer as an argument to left-shift Date: Wed, 4 Dec 2019 18:50:11 +0100 Message-Id: <20191204174334.568891601@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204174327.215426506@linuxfoundation.org> References: <20191204174327.215426506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andy Shevchenko [ Upstream commit f4d7b3e23d259c44f1f1c39645450680fcd935d6 ] 1 << 31 is Undefined Behaviour according to the C standard. Use U type modifier to avoid theoretical overflow. Signed-off-by: Andy Shevchenko Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- include/linux/netdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 0b211d482c961..861b71377e5e1 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -3298,7 +3298,7 @@ static inline u32 netif_msg_init(int debug_value, int default_msg_enable_bits) if (debug_value == 0) /* no output */ return 0; /* set low N bits */ - return (1 << debug_value) - 1; + return (1U << debug_value) - 1; } static inline void __netif_tx_lock(struct netdev_queue *txq, int cpu) -- 2.20.1