Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp804303ybl; Wed, 4 Dec 2019 11:09:58 -0800 (PST) X-Google-Smtp-Source: APXvYqz6ALVv5dvZ3WzHGVPbcdNToDuRegx7osHJRM0Ni0QdVQP0/IwAMxBradwbMMsRTUgo9VJO X-Received: by 2002:a05:6830:14d3:: with SMTP id t19mr3945168otq.278.1575486598101; Wed, 04 Dec 2019 11:09:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575486598; cv=none; d=google.com; s=arc-20160816; b=ZWxLKIEsfuq853Yoh0zcMJRiiPo7yFhqg60NU2MFOd0Ozy7ylekTRauADyx1rTJNeL xuYweGXUR+lyG5/ycFKvrbhbAPbO2CaArm7XeuXsNDlZJYsgGsmt0j5Qr9w8cucM9hJd BKJiHKntZgNU68u90sjKZ/Ud1VKMn0t7fJXSlAdUNT3CGHrwXuph6Welu91wGIVB3d4d bRvDgulzwrN9iQ85cjPclKN+OXu81YbwtqnOaodHB86Gg5PdisLDSdhHdZlxJNBVLRzL MHaFfFFbrWIDB3+51s3YSFSwC64KeEztzvd4ar6yXj5LDxxlfpm5nF1yXAkm7abWJ16M U7cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=lkuT/zwUXO/l8xJuin2AIPKzEQAg/KGHTdElYea+VOw=; b=qBrUrmTthxe4vwro0FVpOgyRmP8ONzQ5OBLQzVLJjX/5sViEodI4zTcsn7XAABMqbg 0msRZbnkLcFQ1IGGiGf/QO9GQRJq73jsuRxfrGUGCiC5jSGUcLQBxzFwQveeXjrSU/Jj KSPce43md6SkF/m5DfWLrJecIELxO3zJg7AA8+7eFFOA1rB1viJJAAHZQvSjmTNUsnNP RKaoHCd/hiY045Tq7y7fvYPnmgTAbpVdms0qBB6hCXwYAUPkT4tGUld0SJi+f3VOqKsn XrcCVPpHf7gnqcDaTdKDE9pZB6mMeq95om9L2XSyDz9izEbVS+oRqBhe1kyTYx00DICE MdRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AqgTkTwn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s82si3625490oif.96.2019.12.04.11.09.44; Wed, 04 Dec 2019 11:09:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AqgTkTwn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730961AbfLDSIt (ORCPT + 99 others); Wed, 4 Dec 2019 13:08:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:60828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730018AbfLDSIf (ORCPT ); Wed, 4 Dec 2019 13:08:35 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9CA02089C; Wed, 4 Dec 2019 18:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482915; bh=bs5/xyBHOfej+Iw29Cr0qxNf9qYZqmH7Je52HSZx7Pg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AqgTkTwnsmVEkRNfiOy58zCCVjXQ7osseV400aDK8zmovWXPq/giPnPeFt2zNepsv pEhJRwrKqBx/6Ya9HkoiGi5D6N0pWPCFqmDPY/WzVCQcQT6S0TNBrZ4PSIdAsb1/BH kPMNPdROXZSCZHKxMsuDfN4nVS8ENc1OTXA8l62M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "huijin.park" , Geert Uytterhoeven , Boris Brezillon , Lee Jones Subject: [PATCH 4.14 184/209] mtd: spi-nor: cast to u64 to avoid uint overflows Date: Wed, 4 Dec 2019 18:56:36 +0100 Message-Id: <20191204175336.157081208@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175321.609072813@linuxfoundation.org> References: <20191204175321.609072813@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: huijin.park commit 84a1c2109d23df3543d96231c4fee1757299bb1a upstream. The "params->size" is defined as "u64". And "info->sector_size" and "info->n_sectors" are defined as unsigned int and u16. Thus, u64 data might have strange data(loss data) if the result overflows an unsigned int. This patch casts "info->sector_size" to an u64. Signed-off-by: huijin.park Reviewed-by: Geert Uytterhoeven Signed-off-by: Boris Brezillon Signed-off-by: Lee Jones Signed-off-by: Greg Kroah-Hartman --- drivers/mtd/spi-nor/spi-nor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -2382,7 +2382,7 @@ static int spi_nor_init_params(struct sp memset(params, 0, sizeof(*params)); /* Set SPI NOR sizes. */ - params->size = info->sector_size * info->n_sectors; + params->size = (u64)info->sector_size * info->n_sectors; params->page_size = info->page_size; /* (Fast) Read settings. */