Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp818369ybl; Wed, 4 Dec 2019 11:22:48 -0800 (PST) X-Google-Smtp-Source: APXvYqyCBpQGWI1beaJhrqUs9CiE4EesIJtdvIIZ8l+7YO8rBAnUek9/MHFv0xdOzO5XmxyfaxJc X-Received: by 2002:aca:190b:: with SMTP id l11mr4114359oii.65.1575487367927; Wed, 04 Dec 2019 11:22:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575487367; cv=none; d=google.com; s=arc-20160816; b=VNbvsdQtaxUDLEeovgMPT5LHF8CEq6cWtibV4UDfRIGVcQ27inkjZ791ExLaaqpVuy Oql+k3tFyrzdRsAqTrIe4mZDWLLNVUn2IkfVPR1nmvzIc+/EXhMX6cXQ2qQiN01jAbiE PRrnA/MxCWX7WqNr6HFn3ei0JHmIg3fhMyi21DVX56LJbup4AE55agyc6jMQu4lidJ8K VkWzyXn2NILyWto3DK9Ax98g7rUTuvRKKW2zEeZr4Mg0onE8QjP2EMAtri9IFmHp2ftq Kn4xZhjsVeP+XxtQ2oTaxpAdiSxreVmFRoIEzvn5XOWDr/TTLpL+CJR4pA9YoMbep6sC eX2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=cz/6qwfspB6nO9WbBhGfgsVUkdWXI9FeG2I578mcxqc=; b=UQajlJIWtOoxILhDym4b/wfDu4bp5SIbj87SDYpfYe7A4yer2X3nT3/phXJSVedmCD fAm6pw+pvSIHHvlipz6LqNEm8L1qnNDjq+nbpNwNkHy+V/dxSYIiSKoGPuNnxPX+wzCR 0fisf5RWl3BTDmWoOMCaxs2Q2n4MtBU6etpLctALlX5yq+pWiDwVJczk4y0Q/EHGsQOt XZXYMrY6NNUc5jxrxM5moeUjdKAduVF5sMzHEXfWInMeerb9E7s9uVKLks5xO2cZRKeh NlbV/xn3x7KUw5Fkw+NQ6m/xFQ+5NeajjSn+wZPgA67L+rVI4x5wJYKwek/K6LgOGMXs hR8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gzNd93WA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c131si3828632oib.267.2019.12.04.11.22.35; Wed, 04 Dec 2019 11:22:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gzNd93WA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729764AbfLDSCG (ORCPT + 99 others); Wed, 4 Dec 2019 13:02:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:43520 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729219AbfLDSCD (ORCPT ); Wed, 4 Dec 2019 13:02:03 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 682E5206DF; Wed, 4 Dec 2019 18:02:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482522; bh=DFBgrIvg0BuTOOkN8cvpbyIpAt5L15g4xAD3vpifjs4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gzNd93WAIS/6+g9CmDA8qCr99t4XOd+9JkwmUhRVlLGz3kF7QmI56JFp5DqDPmN6V dO+VR10y8dglUYaI2jqnjBcWrizqknlxA2ueHfadzQhAG+7Qetb64u9eFG4whpRzsF WMrDqZv4GW1IbkDDlRYONnWsNjf4orCt013Rbxrs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xiaojun Sang , Srinivas Kandagatla , Vinod Koul , Mark Brown , Sasha Levin Subject: [PATCH 4.14 003/209] ASoC: compress: fix unsigned integer overflow check Date: Wed, 4 Dec 2019 18:53:35 +0100 Message-Id: <20191204175321.829108804@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175321.609072813@linuxfoundation.org> References: <20191204175321.609072813@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiaojun Sang [ Upstream commit d3645b055399538415586ebaacaedebc1e5899b0 ] Parameter fragments and fragment_size are type of u32. U32_MAX is the correct check. Signed-off-by: Xiaojun Sang Signed-off-by: Srinivas Kandagatla Acked-by: Vinod Koul Link: https://lore.kernel.org/r/20191021095432.5639-1-srinivas.kandagatla@linaro.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/core/compress_offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c index 2e2d184684911..7ae8e24dc1e61 100644 --- a/sound/core/compress_offload.c +++ b/sound/core/compress_offload.c @@ -529,7 +529,7 @@ static int snd_compress_check_input(struct snd_compr_params *params) { /* first let's check the buffer parameter's */ if (params->buffer.fragment_size == 0 || - params->buffer.fragments > INT_MAX / params->buffer.fragment_size || + params->buffer.fragments > U32_MAX / params->buffer.fragment_size || params->buffer.fragments == 0) return -EINVAL; -- 2.20.1