Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp820409ybl; Wed, 4 Dec 2019 11:25:02 -0800 (PST) X-Google-Smtp-Source: APXvYqxniZjNa4aXzL+1xrEvoTaZBqyh+SHqLzU66oyL9z0pr2nM2fPln/mtc/GYx8lp9qYS8VG5 X-Received: by 2002:aca:3442:: with SMTP id b63mr4132258oia.36.1575487501827; Wed, 04 Dec 2019 11:25:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575487501; cv=none; d=google.com; s=arc-20160816; b=BAjoJbsD5GYQ4yM2+ZJ5CHY3KzSY9wJdxjNlMF5kIioanx1F9BqgF2VgdyzmAdAw30 R/7OWEUg5RNImexQ7TMOrl55ugVVJ75GtVN1PQ5FNjntd41WYJnE6IuZjbqiIckrqKr2 u9/pK5kvzms32l5QDIcYOI+o35R1KwFF8rK01PN9UC5gd+yheUFZdNI8IT8kO8Cv6BpF OkZl7UK3jn4EUgRBRDbh7pINaEqpz9UtI89lfRKSz24REvEajAItoPsl+erd8BPKKUwI 1zkInzueYWqdRvQYF0UamZFeHSKMU7sRgTJF9uP/kxJ9o13pqiGMQE/eDNhg/v2zeF13 94eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fi0isdp46wLMlgUfmcuqz1ONOew3Z8m+dvR+b1wjmZA=; b=drS3dM39V2bj/iW2cZE5cuoUpqsld7lpacsaNRIGJhvg3259D+zLYG56z+oqYkPIH5 /qqbfMiiEw7rfU0vQ0iR5cCC2jahJ3s+d53Up6TfBxnbJnUCY/X7xegx83E8gvg91zl+ lWD7q5Q+fWgJB2hMNGYebM2P4rNhEOeXJ24+TtyzFwBQ+1OTqcT1o0ODrv2PyonBwS+d YhShkJrmpA1zMO0zwITzYsXzyLJDmGeX/eu31gOwPl+rjs5Nwh5WB1LyP9120bR7pZhx aBWJhduch9pqt+3ktsjabAE+BczpuEtZ18PVz9n34+SSQUsfgB9isR8q5hjDLD/QIKJ4 zErw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cyEruBWm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d187si3671368oif.33.2019.12.04.11.24.49; Wed, 04 Dec 2019 11:25:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cyEruBWm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731307AbfLDSKj (ORCPT + 99 others); Wed, 4 Dec 2019 13:10:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:38106 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731297AbfLDSKi (ORCPT ); Wed, 4 Dec 2019 13:10:38 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9631E20674; Wed, 4 Dec 2019 18:10:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575483038; bh=ThoYSDuOyMrEllBnixLtzC0SAlAY938sTf+e4ht6PkE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cyEruBWmubLslg/RiEcQ3SsAZNpgbsWrYUGrjvTWR1JyPThtNM0Ky7Jz0XjVLuhl1 UGEpISXTONNEbnARzj8lH3wLSm94JaHFoYNp3m3EbeC5F8NQSCl77FWRP3DOtK5uP/ mCUbRBGLSuNXWCPWjBvoRRVPejGl9P/FaNJsEdGA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Brian Norris , Kalle Valo , Sasha Levin Subject: [PATCH 4.9 026/125] mwifiex: debugfs: correct histogram spacing, formatting Date: Wed, 4 Dec 2019 18:55:31 +0100 Message-Id: <20191204175319.891222735@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175308.377746305@linuxfoundation.org> References: <20191204175308.377746305@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Brian Norris [ Upstream commit 4cb777c64e030778c569f605398d7604d8aabc0f ] Currently, snippets of this file look like: rx rates (in Mbps): 0=1M 1=2M2=5.5M 3=11M 4=6M 5=9M 6=12M 7=18M 8=24M 9=36M 10=48M 11=54M12-27=MCS0-15(BW20) 28-43=MCS0-15(BW40) 44-53=MCS0-9(VHT:BW20)54-63=MCS0-9(VHT:BW40)64-73=MCS0-9(VHT:BW80) ... noise_flr[--96dBm] = 22 noise_flr[--95dBm] = 149 noise_flr[--94dBm] = 9 noise_flr[--93dBm] = 2 We're missing some spaces, and we're adding a minus sign ('-') on values that are already negative signed integers. Signed-off-by: Brian Norris Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/marvell/mwifiex/debugfs.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/debugfs.c b/drivers/net/wireless/marvell/mwifiex/debugfs.c index ae2b69db59940..6eacea28d7ac8 100644 --- a/drivers/net/wireless/marvell/mwifiex/debugfs.c +++ b/drivers/net/wireless/marvell/mwifiex/debugfs.c @@ -296,15 +296,13 @@ mwifiex_histogram_read(struct file *file, char __user *ubuf, "total samples = %d\n", atomic_read(&phist_data->num_samples)); - p += sprintf(p, "rx rates (in Mbps): 0=1M 1=2M"); - p += sprintf(p, "2=5.5M 3=11M 4=6M 5=9M 6=12M\n"); - p += sprintf(p, "7=18M 8=24M 9=36M 10=48M 11=54M"); - p += sprintf(p, "12-27=MCS0-15(BW20) 28-43=MCS0-15(BW40)\n"); + p += sprintf(p, + "rx rates (in Mbps): 0=1M 1=2M 2=5.5M 3=11M 4=6M 5=9M 6=12M\n" + "7=18M 8=24M 9=36M 10=48M 11=54M 12-27=MCS0-15(BW20) 28-43=MCS0-15(BW40)\n"); if (ISSUPP_11ACENABLED(priv->adapter->fw_cap_info)) { - p += sprintf(p, "44-53=MCS0-9(VHT:BW20)"); - p += sprintf(p, "54-63=MCS0-9(VHT:BW40)"); - p += sprintf(p, "64-73=MCS0-9(VHT:BW80)\n\n"); + p += sprintf(p, + "44-53=MCS0-9(VHT:BW20) 54-63=MCS0-9(VHT:BW40) 64-73=MCS0-9(VHT:BW80)\n\n"); } else { p += sprintf(p, "\n"); } @@ -333,7 +331,7 @@ mwifiex_histogram_read(struct file *file, char __user *ubuf, for (i = 0; i < MWIFIEX_MAX_NOISE_FLR; i++) { value = atomic_read(&phist_data->noise_flr[i]); if (value) - p += sprintf(p, "noise_flr[-%02ddBm] = %d\n", + p += sprintf(p, "noise_flr[%02ddBm] = %d\n", (int)(i-128), value); } for (i = 0; i < MWIFIEX_MAX_SIG_STRENGTH; i++) { -- 2.20.1