Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1f337af9f52ac4c3128e61c971cf0e32068a71ab.camel@linux.ibm.com>
Subject: Re: [PATCH v4 1/2] powerpc/pseries/iommu: Share the per-cpu TCE
 page with the hypervisor.
From:   Leonardo Bras <leonardo@linux.ibm.com>
To:     Ram Pai <linuxram@us.ibm.com>, linuxppc-dev@lists.ozlabs.org,
        mpe@ellerman.id.au
Cc:     andmike@us.ibm.com, mst@redhat.com, aik@ozlabs.ru,
        mdroth@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
        ram.n.pai@gmail.com, cai@lca.pw, tglx@linutronix.de,
        sukadev@linux.vnet.ibm.com, hch@lst.de, bauerman@linux.ibm.com,
        david@gibson.dropbear.id.au
Date:   Wed, 04 Dec 2019 15:26:50 -0300
In-Reply-To: <1575269124-17885-2-git-send-email-linuxram@us.ibm.com>
References: <1575269124-17885-1-git-send-email-linuxram@us.ibm.com>
         <1575269124-17885-2-git-send-email-linuxram@us.ibm.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-xOP3QrA+adzjZyTY2Uvc"
User-Agent: Evolution 3.34.1 (3.34.1-1.fc31) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-xOP3QrA+adzjZyTY2Uvc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, 2019-12-01 at 22:45 -0800, Ram Pai wrote:
> @@ -206,8 +224,7 @@ static int tce_buildmulti_pSeriesLP(struct iommu_tabl=
e *tbl, long tcenum,
>          * from iommu_alloc{,_sg}()
>          */
>         if (!tcep) {
> -               tcep =3D (__be64 *)__get_free_page(GFP_ATOMIC);
> -               /* If allocation fails, fall back to the loop implementat=
ion */
> +               tcep =3D alloc_tce_page();
>                 if (!tcep) {
>                         local_irq_restore(flags);
>                         return tce_build_pSeriesLP(tbl, tcenum, npages, u=
addr,

The comment about failing allocation was removed, but I see no chage of
behaviour here.=20

Can you please explain what/where it changes?=20

Best regards,

Leonardo

--=-xOP3QrA+adzjZyTY2Uvc
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEMdeUgIzgjf6YmUyOlQYWtz9SttQFAl3n+moACgkQlQYWtz9S
ttRN3xAA5oyWECPthDRG8RJVWpXNBntk5Q5p2NArYbJ2lPJPtQUZ4n1jTrXU9jzH
3lJ/fgi3X3uKzDt85ZJRN7r8Q/EvSH7GQwS8615PSzkQ+7pR2ncdsJNiW99Q5/AF
PxLiygpyAYCIAvfQVyHS5zpdIMDmQ2jX2Pw9KOLMyBhcm1SdI60y6H3FYr3ihXUo
iswyg49W/jc7u2MwpX5T4p4CS8aUHdaZLKePpGTwI7feZaJNYZkuCSecC35vuBBB
9zuLFWh1bXQ78U+B3eikQr8HP13xuHMkOo3gN2OhBKhREO4VSfkMQ76W3Zko9HE3
+T7kxanN+fThP9cVzV6Lvee1mgt7C2rOMdcL9/VnAQ8VkbhSpnUxkDGBA6CrFadF
rdspu4FdWdlbI9JW3fGjcSGFtwzPkIV9JV3YfQsUKvUDZro10dwoeYwjv/cVcOlH
UFQByrOSa26k4rAFrlnD1YmZJyY5GHnkk3dIhzq1my96foYC2ucOO1tNSMyHkyuT
Hr23JAxFO3QSqhc4093l+MxiirP5VAsOyXQFcYLMtWV2gw1FKVRumenBTWt6hIDR
ATnM6uj5TUOx5R/rI+XhAJj5ar5XMdRU8CsbmTh1zHd0laz3k62z7z5B0HhhfPzd
JBbkysHhunvUUs9J0s+STdyScofunsbTx9j0Pchhgwbeb9bB+XA=
=axXy
-----END PGP SIGNATURE-----

--=-xOP3QrA+adzjZyTY2Uvc--