Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp990405ybl; Wed, 4 Dec 2019 14:42:16 -0800 (PST) X-Google-Smtp-Source: APXvYqyxg0Lma7Qeb2wj66yKpxfqTQveTjIMAt29g/nZwFCgSxOLoYs6HTJNWFKNabzypGHwHuxw X-Received: by 2002:a54:4e94:: with SMTP id c20mr4818313oiy.27.1575499336600; Wed, 04 Dec 2019 14:42:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575499336; cv=none; d=google.com; s=arc-20160816; b=PD7JzeAR+/fNU2/OkWhYpn0FQMwuzhElWIj+/UhMyoYPb4ijBPwNDSdrsQadO2SzGh 2GdmfMETYNeJtm8RAx5+UtkCXF+8ERxMDSUYF0e5NbODj3oQKmWjGDbSbf1izr48Je/v iRPH2z24LgrFKX3jhrfD7geBO3UWGnNu8HKcOWm+YFgVlZb/nKtjRZ2tsL3t/1/pFD2z MVvaqF6wahGgly+cdfypseY5igWtS4vLSAhnYhls0Xkr7E2xRoKRswJkGGpHoStmYH1K BqDCN1m9fO0LllRfhF4k1/LrvBGu9HMLRYr4LLCut+8gk46zM4+IMJ1ySj35aWrKlEle z7zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=Hygomg0IkjBeTUP6XSMjFJvucT6fovHpF5/8RvY72oU=; b=L+jXXqZydOh1GPTMAtv64SJu0+lrKW5JZcJQGZQ7S1eH9MFJlCGnBsf667hFKFRvv1 TG0OkfVhNIDEZ4tpEYZo41vzUVkS04s5Gz5QE0v1iguJbTwbY1nunjGOEhmjyIciqBiv 3nrZcFZBfPbfk4d6E8Du5CHQeWoRVHvQUlLVgKJIRRf+uGcb+eu5e0FGTK1LWiidqtXB 53HKxVi1jrwIyQtdLnXg2atrJAMVLtO1/s9hkdCb6z+w9GqbqRqXh5RfTQ5IMr2c7DNp hg7QDyPWbhun4xuG1Zq7RI54KDBkny92vSpW5cQjJZe1XklnEV5J3ibPp4jEakvDRtBS +ENw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=iJRKu8W0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b6si535851oiy.116.2019.12.04.14.42.04; Wed, 04 Dec 2019 14:42:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=iJRKu8W0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728392AbfLDWli (ORCPT + 99 others); Wed, 4 Dec 2019 17:41:38 -0500 Received: from linux.microsoft.com ([13.77.154.182]:50126 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728238AbfLDWlh (ORCPT ); Wed, 4 Dec 2019 17:41:37 -0500 Received: from nramas-ThinkStation-P520.corp.microsoft.com (unknown [131.107.174.108]) by linux.microsoft.com (Postfix) with ESMTPSA id 247E520B4761; Wed, 4 Dec 2019 14:41:37 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 247E520B4761 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1575499297; bh=Hygomg0IkjBeTUP6XSMjFJvucT6fovHpF5/8RvY72oU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iJRKu8W0djMen2xh9DrpDAo0rF3rXzhrlVJrODNqahFlmyA0mKvV7EmIoeeiz1Yyx ANmrDneGPBpfbewZra4kLsH93NLJZKmfSBQ08/JVObz5CbGkraEFqvYWNYib84tLc+ G2kf5qBKTceHtoKSAvHYEkImNDzS87JWdVR7/zRQ= From: Lakshmi Ramasubramanian To: zohar@linux.ibm.com, linux-integrity@vger.kernel.org Cc: eric.snowberg@oracle.com, dhowells@redhat.com, mathew.j.martineau@linux.intel.com, matthewgarrett@google.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org Subject: [PATCH v10 1/6] IMA: Check IMA policy flag Date: Wed, 4 Dec 2019 14:41:26 -0800 Message-Id: <20191204224131.3384-2-nramas@linux.microsoft.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191204224131.3384-1-nramas@linux.microsoft.com> References: <20191204224131.3384-1-nramas@linux.microsoft.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return immediately from process_buffer_measurement() if the IMA policy flag is set to zero. Not doing this can result in kernel panic when process_buffer_measurement() is called before IMA is initialized (for instance, when the IMA hook is called when a key is added to the .builtin_trusted_keys keyring). This change adds the check in process_buffer_measurement() to return immediately if ima_policy_flag is set to zero. Signed-off-by: Lakshmi Ramasubramanian --- security/integrity/ima/ima_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c index d7e987baf127..9b35db2fc777 100644 --- a/security/integrity/ima/ima_main.c +++ b/security/integrity/ima/ima_main.c @@ -655,6 +655,9 @@ void process_buffer_measurement(const void *buf, int size, int action = 0; u32 secid; + if (!ima_policy_flag) + return; + /* * Both LSM hooks and auxilary based buffer measurements are * based on policy. To avoid code duplication, differentiate -- 2.17.1