Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1094455ybl; Wed, 4 Dec 2019 16:56:15 -0800 (PST) X-Google-Smtp-Source: APXvYqyX6WXs9EjJ75rZlE2kzWil52yiC7NChM6Wgy3dae+eFqj7pRxIZ3qMVScx4xluZ7KKAtCT X-Received: by 2002:aca:3755:: with SMTP id e82mr5361347oia.19.1575507375210; Wed, 04 Dec 2019 16:56:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575507375; cv=none; d=google.com; s=arc-20160816; b=cNczbIKQAlpuyCO7Z19bvTqqrapJ2H9irpyUm4XvWvHOavsHDGZiTRXI+VmVUY/ZNk QU2yvHXpe8LGqg90YrA3++tRJ9w7cvARXctE5j4uz/dY0GxUgllW6Bzruf8JMndT+ZiL vXHcpcXbUggBoR2dBNO7P+f4Ary4df6Jkmm6OJgZxhYqiiWa3n6HQF0iGPj0cgLiPO7b 7D+GDngR15ZNWI3wAWbXQ5tO83OXYjExka0JtagNGYDYRZwrdW+WPljxc5jZG7mMiaOa TWSIZ6g/GKKkdt5QmRQ7ckeyCDw3QADiGpP1seeCIf86XYiPM0Hd+x+YKDiFDY8oeaWA e/8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=42keQQhwXzE9u8h3iYvvedZi53WXhWluwjmIWm1gKVE=; b=C4dX8ZVexHiYOAykR18xc7MKEtOqG8biUZoEMp8vy15KctEnBVTR/hwQiy3A3R4vrV unaqKdVb9c2evhAmHUZUlHhi53ZRsqRCjo5jgjJFhk+E5jwJkAp/sIZ0YuxQIpx+Otcr +seb8OxXr6BvEO4HBF3r4E2uoUgorYQ/u+QH3yt5uidglm2UtWSm6QlmzvzaZtjDyGYi 9Yt3bWHfkTdWAxEaii23Nwn9C9WJEcz69vQYqfsccEaKEEUhZMbyurpnpu/QNyCjg4wg NX7otClfs2wAkC57sIMcLn5iXjgcpYceylF+pgecJTyEOVGuk6cAepQCHTJBncUEINlr yv/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a20si4332863otf.271.2019.12.04.16.56.02; Wed, 04 Dec 2019 16:56:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728522AbfLEAza (ORCPT + 99 others); Wed, 4 Dec 2019 19:55:30 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:38358 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728011AbfLEAza (ORCPT ); Wed, 4 Dec 2019 19:55:30 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 777EA14F2F78D; Wed, 4 Dec 2019 16:55:29 -0800 (PST) Date: Wed, 04 Dec 2019 16:55:28 -0800 (PST) Message-Id: <20191204.165528.1483577978366613524.davem@davemloft.net> To: jakub.kicinski@netronome.com Cc: willemdebruijn.kernel@gmail.com, vvidic@valentin-vidic.from.hr, borisp@mellanox.com, aviadye@mellanox.com, john.fastabend@gmail.com, daniel@iogearbox.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/tls: Fix return values for setsockopt From: David Miller In-Reply-To: <20191204150136.2f001242@cakuba.netronome.com> References: <20191204.125135.750458923752225025.davem@davemloft.net> <20191204150136.2f001242@cakuba.netronome.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 04 Dec 2019 16:55:29 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jakub Kicinski Date: Wed, 4 Dec 2019 15:01:36 -0800 > Valentin, what's the strategy you're using for this fix? There's a > bunch of ENOTSUPP in net/tls/tls_sw.c as well, could you convert those, > too? Yes I see those as well, let's get them all in one patch ok?