Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andy Duan <fugang.duan@nxp.com>
To:     Peng Fan <peng.fan@nxp.com>,
        "srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
CC:     "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Aisheng Dong <aisheng.dong@nxp.com>
Subject: RE: [PATCH] nvmem: imx: scu: correct the fuse word index
Thread-Topic: [PATCH] nvmem: imx: scu: correct the fuse word index
Thread-Index: AQHVqmb3nxYwp0MksEa8htHeEretqKeqwU1w
Date:   Thu, 5 Dec 2019 01:27:19 +0000
Message-ID: <VI1PR0402MB3600684CB1E283E73925FE66FF5C0@VI1PR0402MB3600.eurprd04.prod.outlook.com>
References: <1575438591-12409-1-git-send-email-peng.fan@nxp.com>
In-Reply-To: <1575438591-12409-1-git-send-email-peng.fan@nxp.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b958a537-4dff-4353-8325-08d779224564
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2019 01:27:19.3949
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rrjiCBtYSht+JC5it5xOWssMJVQ4wGNLSeS54LpW2QXuyEyFs79Qh/kKQi50UxVdV7tbZQ+t26vybKJpWuznPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3823
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Peng Fan <peng.fan@nxp.com> Sent: Wednesday, December 4, 2019 1:52 PM
> From: Peng Fan <peng.fan@nxp.com>
>=20
> i.MX8 fuse word row index represented as one 4-bytes word.
> Exp:
> - MAC0 address layout in fuse:
> offset 708: MAC[3] MAC[2] MAC[1] MAC[0]
> offset 709: XX     xx     MAC[5] MAC[4]
>=20
> The original code takes row index * 4 as the offset, this not exactly mat=
ch
> i.MX8 fuse map documentation.
>=20
> So update code the reflect the truth.
>=20
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Fugang Duan <fugang.duan@nxp.com>
> ---
>  drivers/nvmem/imx-ocotp-scu.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/nvmem/imx-ocotp-scu.c b/drivers/nvmem/imx-ocotp-scu.=
c
> index 455675dd8efe..399e1eb8b4c1 100644
> --- a/drivers/nvmem/imx-ocotp-scu.c
> +++ b/drivers/nvmem/imx-ocotp-scu.c
> @@ -138,8 +138,8 @@ static int imx_scu_ocotp_read(void *context,
> unsigned int offset,
>  	void *p;
>  	int i, ret;
>=20
> -	index =3D offset >> 2;
> -	num_bytes =3D round_up((offset % 4) + bytes, 4);
> +	index =3D offset;
> +	num_bytes =3D round_up(bytes, 4);
>  	count =3D num_bytes >> 2;
>=20
>  	if (count > (priv->data->nregs - index)) @@ -168,7 +168,7 @@ static int
> imx_scu_ocotp_read(void *context, unsigned int offset,
>  		buf++;
>  	}
>=20
> -	memcpy(val, (u8 *)p + offset % 4, bytes);
> +	memcpy(val, (u8 *)p, bytes);
>=20
>  	mutex_unlock(&scu_ocotp_mutex);
>=20
> @@ -188,10 +188,10 @@ static int imx_scu_ocotp_write(void *context,
> unsigned int offset,
>  	int ret;
>=20
>  	/* allow only writing one complete OTP word at a time */
> -	if ((bytes !=3D 4) || (offset % 4))
> +	if (bytes !=3D 4)
>  		return -EINVAL;
>=20
> -	index =3D offset >> 2;
> +	index =3D offset;
>=20
>  	if (in_hole(context, index))
>  		return -EINVAL;
> --
> 2.16.4