Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: GnT8WoR5DhqPa/PxxAzPe2nMiMVelEuyFMg2MMNgryTxVjX4T7aTHfci/0tu6D7GmW9WrUdEds
 d4MLO0Qduk+JcMoHIn8Q3XVpXQlqYNO7w7hFYMLGW5Hr7RjmmtUvuzRNB4+2A5PMxabnfZ3gz5
 7NU7HLu8GTgPtRY/RRoXO9JaX+/iHbTnn0VKy8XvVHvT8TBW8xxsX5xGj376bkM0hzPehphLo2
 6sukNlJ7BI28+P4rVoy+4Z5zg/GvC5zHvsiyuu7FWrrXlMjYuvJ1I3cXlGnwtDAPYWgIt9oaE0
 Znk=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Can Guo <cang@codeaurora.org>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "nguyenb@codeaurora.org" <nguyenb@codeaurora.org>,
        "rnayak@codeaurora.org" <rnayak@codeaurora.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>,
        "saravanak@google.com" <saravanak@google.com>,
        "salyzyn@google.com" <salyzyn@google.com>
CC:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v6 1/5] scsi: Adjust DBD setting in mode sense for caching
 mode page per LLD
Thread-Topic: [PATCH v6 1/5] scsi: Adjust DBD setting in mode sense for
 caching mode page per LLD
Thread-Index: AQHVqxG7B53GU4JD7EG9S3YG2hVoAaerH8+w
Date:   Thu, 5 Dec 2019 07:10:54 +0000
Message-ID: <MN2PR04MB6991724DFB7DCEF5DA43EC5AFC5C0@MN2PR04MB6991.namprd04.prod.outlook.com>
References: <1575512052-15999-1-git-send-email-cang@codeaurora.org>
 <0101016ed3d643f9-ffd45d6c-c593-4a13-a18f-a32da3d3bb97-000000@us-west-2.amazonses.com>
In-Reply-To: <0101016ed3d643f9-ffd45d6c-c593-4a13-a18f-a32da3d3bb97-000000@us-west-2.amazonses.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: be21af21-b7bf-4cea-c38a-08d779524527
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2019 07:10:54.9921
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 96tCtPYAJ9ZV+LsBLsaqpli7vor4doQee/v/9p7oLEnkwWJkBLEoDNKAX4tH34sLKEUk8/na0Ai3GO0cM2SdVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB7086
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> UFS JEDEC standards require DBD field to be set to 1 in mode sense comman=
d.
> This patch allows LLD to define the setting of DBD if required.
>=20
> Signed-off-by: Can Guo <cang@codeaurora.org>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
>  drivers/scsi/scsi_lib.c    | 2 ++
>  include/scsi/scsi_device.h | 1 +
>  2 files changed, 3 insertions(+)
>=20
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index
> 5447738..3812e90 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -2108,6 +2108,8 @@ void scsi_exit_queue(void)
>=20
>         memset(data, 0, sizeof(*data));
>         memset(&cmd[0], 0, 12);
> +
> +       dbd =3D sdev->set_dbd_for_ms ? 8 : dbd;
>         cmd[1] =3D dbd & 0x18;    /* allows DBD and LLBA bits */
>         cmd[2] =3D modepage;
>=20
> diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h inde=
x
> 3ed836d..f8312a3 100644
> --- a/include/scsi/scsi_device.h
> +++ b/include/scsi/scsi_device.h
> @@ -172,6 +172,7 @@ struct scsi_device {
>                                      * because we did a bus reset. */
>         unsigned use_10_for_rw:1; /* first try 10-byte read / write */
>         unsigned use_10_for_ms:1; /* first try 10-byte mode sense/select =
*/
> +       unsigned set_dbd_for_ms:1; /* Set "DBD" field in mode sense */
>         unsigned no_report_opcodes:1;   /* no REPORT SUPPORTED OPERATION
> CODES */
>         unsigned no_write_same:1;       /* no WRITE SAME command */
>         unsigned use_16_for_rw:1; /* Use read/write(16) over read/write(1=
0) */
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum=
,
> a Linux Foundation Collaborative Project