Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Yannick FERTRE <yannick.fertre@st.com>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Rob Herring <robh+dt@kernel.org>
CC:     Philippe CORNU <philippe.cornu@st.com>,
        Benjamin GAIGNARD <benjamin.gaignard@st.com>,
        Bastien Nocera <hadess@hadess.net>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] Input: goodix - support gt9147 touchpanel
Thread-Topic: [PATCH] Input: goodix - support gt9147 touchpanel
Thread-Index: AQHVpQ11LDOqyllChkeeHL9myer67qekjkoAgAayLbA=
Date:   Thu, 5 Dec 2019 08:30:26 +0000
Message-ID: <bd51e553feb74f6fb3a7115463d52e66@SFHDAG6NODE1.st.com>
References: <1574850526-13518-1-git-send-email-yannick.fertre@st.com>
 <20191201030818.GM248138@dtor-ws>
In-Reply-To: <20191201030818.GM248138@dtor-ws>
Accept-Language: fr-FR, en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello,
Dmitry,
I forgot to modify the binding to declare the new compatible "gt9147".
Rob,
can I modify the binding without converting it first to yaml?

Best regards

Yannick Fertr=E9

-----Original Message-----
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>=20
Sent: dimanche 1 d=E9cembre 2019 04:08
To: Yannick FERTRE <yannick.fertre@st.com>; Rob Herring <robh+dt@kernel.org=
>
Cc: Philippe CORNU <philippe.cornu@st.com>; Benjamin GAIGNARD <benjamin.gai=
gnard@st.com>; Bastien Nocera <hadess@hadess.net>; linux-input@vger.kernel.=
org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: goodix - support gt9147 touchpanel

On Wed, Nov 27, 2019 at 11:28:46AM +0100, Yannick Fertre wrote:
> From: Yannick Fertr=E9 <yannick.fertre@st.com>
>=20
> Add support for it by adding compatible and supported chip data=20
> (default settings used).
> The chip data on GT9147 is similar to GT912, like
> - config data register has 0x8047 address
> - config data register max len is 240
> - config data checksum has 8-bit

If it is compatible with gt912 then the driver does not need another compat=
ible in the code I think. Rob will tell more.

>=20
> Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
> ---
>  drivers/input/touchscreen/goodix.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/input/touchscreen/goodix.c=20
> b/drivers/input/touchscreen/goodix.c
> index fb43aa7..b470773 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -1045,6 +1045,7 @@ static const struct of_device_id goodix_of_match[] =
=3D {
>  	{ .compatible =3D "goodix,gt9271" },
>  	{ .compatible =3D "goodix,gt928" },
>  	{ .compatible =3D "goodix,gt967" },
> +	{ .compatible =3D "goodix,gt9147",},
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, goodix_of_match);
> --
> 2.7.4
>=20

--=20
Dmitry