Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191204155941.17814-1-brgl@bgdev.pl> <20191204155941.17814-2-brgl@bgdev.pl>
 <CAHp75VcqYsKUzxGUhn8aHg_u-B=FkqmTU2YS+yyVNfAPu+715w@mail.gmail.com>
In-Reply-To: <CAHp75VcqYsKUzxGUhn8aHg_u-B=FkqmTU2YS+yyVNfAPu+715w@mail.gmail.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Thu, 5 Dec 2019 10:45:01 +0100
Message-ID: <CAMRc=MfFLPJQ6zqSPEymzK0jbdMBNRZjD-PEjrs0G5Jy2f5skw@mail.gmail.com>
Subject: Re: [PATCH v2 11/11] tools: gpio: implement gpio-watch
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Kent Gibson <warthog618@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

=C5=9Br., 4 gru 2019 o 23:42 Andy Shevchenko <andy.shevchenko@gmail.com> na=
pisa=C5=82(a):
>
> On Wed, Dec 4, 2019 at 7:19 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > Add a simple program that allows to test the new LINECHANGED_FD ioctl()=
.
>
> > --- a/tools/gpio/.gitignore
> > +++ b/tools/gpio/.gitignore
> > @@ -1,4 +1,5 @@
> >  gpio-event-mon
> >  gpio-hammer
> >  lsgpio
> > +gpio-watch
>
> Perhaps keep it sorted?
>

Sure I can do this.

> > +++ b/tools/gpio/gpio-watch.c
> > @@ -0,0 +1,112 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * gpio-watch - monitor unrequested lines for property changes using t=
he
> > + *              character device
> > + *
> > + * Copyright (C) 2019 BayLibre SAS
> > + * Author: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > + */
> > +
> > +#include <ctype.h>
> > +#include <errno.h>
> > +#include <fcntl.h>
> > +#include <linux/gpio.h>
> > +#include <poll.h>
> > +#include <stdbool.h>
> > +#include <stdio.h>
> > +#include <stdlib.h>
> > +#include <string.h>
> > +#include <sys/ioctl.h>
> > +#include <unistd.h>
> > +
> > +static bool isnumber(const char *str)
> > +{
> > +       size_t sz =3D strlen(str);
> > +       int i;
> > +
> > +       for (i =3D 0; i < sz; i++) {
> > +               if (!isdigit(str[i]))
> > +                       return false;
> > +       }
> > +
> > +       return true;
> > +}
>
> strtoul() will do the same.
>
> char *p;
> unsigned long dummy; // do we need it?
> dummy =3D strtoul(..., &p);
> return *p =3D=3D '\0';

Yeah strtoul does allow for error checking. I'll change this in v3.

>
> > +int main(int argc, char **argv)
> > +{
> > +       struct gpioline_info_changed chg;
> > +       struct gpioline_info req;
> > +       struct pollfd pfd;
> > +       int fd, i, j, ret;
> > +       char *event;
> > +       ssize_t rd;
> > +
> > +       if (argc < 3)
> > +               goto err_usage;
> > +
> > +       fd =3D open(argv[1], O_RDWR | O_CLOEXEC);
> > +       if (fd < 0) {
> > +               perror("unable to open gpiochip");
> > +               return EXIT_FAILURE;
> > +       }
> > +
> > +       for (i =3D 0, j =3D 2; i < argc - 2; i++, j++) {
> > +               if (!isnumber(argv[j]))
> > +                       goto err_usage;
> > +
> > +               memset(&req, 0, sizeof(req));
> > +               req.line_offset =3D atoi(argv[j]);
>
> Oh, why not to call strtoul() directly?
>
> > +
> > +               ret =3D ioctl(fd, GPIO_GET_LINEINFO_WATCH_IOCTL, &req);
> > +               if (ret) {
> > +                       perror("unable to set up line watch");
>
> Don't you need to unwatch previously added ones?

Nah, we're exiting anyway, the fd will be released.

>
> > +                       return EXIT_FAILURE;
> > +               }
> > +       }
>
> > +       for (;;) {
> > +               ret =3D poll(&pfd, 1, 5000);
> > +               if (ret < 0) {
> > +                       perror("error polling the linechanged fd");
> > +                       return EXIT_FAILURE;
> > +               } else if (ret > 0) {
> > +                       memset(&chg, 0, sizeof(chg));
>
> > +                       rd =3D read(pfd.fd, &chg, sizeof(chg));
> > +                       if (rd < 0 || rd !=3D sizeof(chg)) {
> > +                               if (rd !=3D sizeof(chg))
> > +                                       errno =3D EIO;
> > +
> > +                               perror("error reading line change event=
");
> > +                               return EXIT_FAILURE;
> > +                       }
>
> Shouldn't we handle the -EINTR?

Indeed we should. Will fix.

Bart

>
> > +               }
> > +       }
> > +
> > +       return 0;
>
>
> --
> With Best Regards,
> Andy Shevchenko