Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1729225ybl; Thu, 5 Dec 2019 06:12:09 -0800 (PST) X-Google-Smtp-Source: APXvYqyWQjMZYE9BKpqQAIZwmcN6m3RjTZ3GlYW6te9zLT5aXUxMevutulp0ayelV4tVia9dPZTl X-Received: by 2002:a05:6830:14d5:: with SMTP id t21mr5740372otq.324.1575555128837; Thu, 05 Dec 2019 06:12:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575555128; cv=none; d=google.com; s=arc-20160816; b=DSAD7tYua0ACHqt+FmM3DxbdtnuWkg/Ssyrzh0XV5+qwJaYuCi2IxhfvHzJYIDjt46 7/ufP4TgfKQYytyPmoeFbSlJfQj0IHFZI9fgmm3YfaNH6UgCBdZ27qpmisOzgCxfTU78 +3J8xNtXklygsc3Oh3HfXsEptyFtPmCbHjC33x3XfRAT2ppjkar0DhwDzlQt7ygqkC/Q f5oQrYWArErFTnldOrDZlDX4pjI6d57vDy9IrrJ/WsJHWJjzcG5QYkp915OMdUZESK9j MLDDrEaUQjiEcsbULwbr+UlB1hf1+7tuk2INem0rMgNbLoMW4iyvFxE13CSu0ZJ3PZZ2 YScw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=NdRk0/WJY6q/NMtsungMXpX9nQb52EUzCZp5dxdBiDo=; b=lOrooK2i4DlBzj4J8LXEA6Iw7IfnqWQ2FZNad1GCNzbRS4DZEtmt9ZzhFvwELYIM4S enCU929NaVy8iyM3yTFun53fomZUrWwPoXLr4qWSGlW60FdVB2kvT1jez84dpwf2hz29 URLyWgzj4dia6/SL2B1ZpATFMSZQnPCp5eWSQwR0AkX3/kOXpm+qwsxPwaC+Hi9SRPMN jwRyrnoTmh6wA1J/U3oobLTXE/3XASz/bh1QTV3gFdaqbxYqEUXEHLn8PChKiKkW7/U2 iyFh7dtFVhtkLpwV7YBDfYZhABL7WAzqNnbxnVtEny3w1h46doUL5yutpZZAtWvG60PF KQ9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=s2a2GSfz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s206si4957661oib.73.2019.12.05.06.11.56; Thu, 05 Dec 2019 06:12:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=s2a2GSfz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729574AbfLEOJ7 (ORCPT + 99 others); Thu, 5 Dec 2019 09:09:59 -0500 Received: from mail-il1-f193.google.com ([209.85.166.193]:41559 "EHLO mail-il1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729540AbfLEOJ7 (ORCPT ); Thu, 5 Dec 2019 09:09:59 -0500 Received: by mail-il1-f193.google.com with SMTP id z90so3083491ilc.8 for ; Thu, 05 Dec 2019 06:09:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=NdRk0/WJY6q/NMtsungMXpX9nQb52EUzCZp5dxdBiDo=; b=s2a2GSfzBzKRVsd+y4on5r5AAqvHvkht2ps+r4RS1KKyGeBVN8Z1qlKDyUziyi3Zc6 yWi9p9aDDyvVmDydac/apXnIR6wLQp9kVdSOBVNS5iVPCj4kXHoPV/ngMBUO/ZLO777X jwsvUMR29lHN5ATMpbKzK0E6rACPmzSnbGftP9d4Dq24+RqiRHs6gusv8y2h6PVQjn0G adNZbUX8kpKRnIt8RPYyE4dBcheAx8CAlQH16U+BZvIk0IcCeUdDw/l9FRBJaDZlOVg1 p9ZAKiSGSXdObAu/1NIPuiNMTq5Ca1rr0x5jRS57Rk8WGym72d6zio+txaRLEOgsueSB 0ZRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NdRk0/WJY6q/NMtsungMXpX9nQb52EUzCZp5dxdBiDo=; b=blmxK+jDjTlCIJq8xLQ7fKqkYn5QpuoAg+cYo855Tq6YLMmJOGMcKMIVY93TK4QDQ6 4BHBBcIzgih6oenBR/jPHNudSeMwlJcbWqRYkE+1m9oFmEoJxKcZSG6CmfW1FYjrrNrV BCAWD3eFfPRW9H5AHfy0CnWK7OhDJ6W9aLZrQt4qmWwbvCYbhEy7RJ+GddLSmGPW7n6x lRm/KMdnPhAnH9Vje78DxuT6Bwuj6KeB9CRXyakOP9wWtVkk6ZD9TbDO3veIyIYIiFuL PP7FbIXsk1huW9+y58JJzZ0IpXcuXVZRvvpuYcFm5S4lj4MZrqVfY6/G+3Vrb8aRKFPf 4BFQ== X-Gm-Message-State: APjAAAU8uYIpXZ5nBkkf3akMfhDhXbqv92yZhrNguVVH/kl+dLDn+Bu+ gYhcGaUnnLeH93JlR6acoG8+2Fg4A246IQ== X-Received: by 2002:a92:9107:: with SMTP id t7mr9019531ild.51.1575554998080; Thu, 05 Dec 2019 06:09:58 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id s8sm2814777ilq.14.2019.12.05.06.09.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Dec 2019 06:09:57 -0800 (PST) Subject: Re: [PATCH] io_uring: hook all linked requests via link_list To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <49ba20e17803a7caf1cb87792b36dd40b4a99806.1575551693.git.asml.silence@gmail.com> From: Jens Axboe Message-ID: Date: Thu, 5 Dec 2019 07:09:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <49ba20e17803a7caf1cb87792b36dd40b4a99806.1575551693.git.asml.silence@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/5/19 6:16 AM, Pavel Begunkov wrote: > Links are created by chaining requests through req->list with an > exception that head uses req->link_list. (e.g. link_list->list->list) > Because of that, io_req_link_next() needs complex splicing to advance. > > Link them all through list_list. Also, it seems to be simpler and more > consistent IMHO. Agree, much easier to grok and verify. Applied, thanks. -- Jens Axboe