Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1901637ybl; Thu, 5 Dec 2019 08:45:47 -0800 (PST) X-Google-Smtp-Source: APXvYqydIqvunzipMvUVba7Z3RUCvq3m+XOm/UcDpNu4cRlaolpbDGotRpYbYWYgSYLrucJT1HDH X-Received: by 2002:aca:ddc2:: with SMTP id u185mr2396053oig.174.1575564347187; Thu, 05 Dec 2019 08:45:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575564347; cv=none; d=google.com; s=arc-20160816; b=T4IYIHHCRrTsfLHxuLQUvMvNyzOI/SPZiXkWbEOSFzaQjc3ska6DOiYVJ/lII0GRQ9 sIpSOEPHoZutyEaWFanWNHvtviAYbTZaFiXCtR2z/m4NyeuRCHlYckCU4NWxfypYkshe VD4igz8g1C6PumQOFxrGkAkavj7DVnDsL5Oqat9o5pewiOMGqBWNlO6QGTVn0Ox7htC3 t6jydcHp3MIHk6Qe8pRhqEM3muovmuL7wawSG69HCMkVLNyHtRy7+d90Etq1VmDzeYuA UHvxjo8ngp1o+TGArhDIlw08JMlRBwFqTrQUCiFptBFbspOutB2LFF3MDbObwb4ixdKn 7GEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=6vl8JViFklIhc7mM8btfIaDHfZRW9HAgFjjeBb/dcdk=; b=plOR00BxrIhEmIdKJ+2XCPG9iYLYaxtMJ8guO80Wn5ruOD33qlCX5HHmIN9WG0I2M9 upmLI9odCIMv1EYIlip/++EeV0EPWPkUmSCQlzbUmzJfHAVwWibI0n4ieymQGm8iqycP +zEQy3pz5K5jKL9cZlkszsXbCcZL7RFBFlv3h2tugsVKvA8kdZZRYQ9AmHZYg9rKnEGn fZ2xmGwDSoEgDvOTsY+nQWC2cd30nSzDIIQb/hsO6Mmmr70LzdKFN/UTnwhAmN7JGZ3m vFJVyFtsr55sME8ssFfaG/D8QryIHRd1hoBsCZMgKogfr7MTmRYvtRL3vngs2YbOETQm AKjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GjhHrEVG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d67si5363671oig.112.2019.12.05.08.45.33; Thu, 05 Dec 2019 08:45:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GjhHrEVG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729530AbfLEQpE (ORCPT + 99 others); Thu, 5 Dec 2019 11:45:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:57720 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726028AbfLEQpE (ORCPT ); Thu, 5 Dec 2019 11:45:04 -0500 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6148C22525; Thu, 5 Dec 2019 16:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575564303; bh=0GzTDoBdLY2bbfEGu+zYgBeHJui7THhwDhp74AzjIUw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=GjhHrEVGH25V1XIDqR+ipuATeio+84sWGUfawJejo8Ptb0Wka9bbolWlARdbYCqmh 8qCzVaDWj/V+STb2sDp6iD1Yejfk+oA8rjOYyDxenRnxXAUXjtJoITPdYgGcacYzPq oMoazsq4+7Rqf3M7G7mFUzI99mtkdy7QO1Ep5MzE= Subject: Re: [BUGFIX PATCH v2 0/3] selftests: safesetid: Fix some bugs in safesetid test To: Micah Morton , Masami Hiramatsu Cc: linux-kselftest@vger.kernel.org, Linux Kernel Mailing List , jaswinder.singh@linaro.org, shuah References: <157554844882.11018.13436399905210284553.stgit@devnote2> From: shuah Message-ID: <3bad79d5-eada-7e96-4210-c4888bfb710f@kernel.org> Date: Thu, 5 Dec 2019 09:44:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/5/19 9:40 AM, Micah Morton wrote: > On Thu, Dec 5, 2019 at 4:20 AM Masami Hiramatsu wrote: >> >> Hi, >> >> Here is the v2 series to fix build warnings and erorrs on >> kselftest safesetid. >> This version includes a fix for a runtime error. >> >> Thank you, >> >> --- >> >> Masami Hiramatsu (3): >> selftests: safesetid: Move link library to LDLIBS >> selftests: safesetid: Check the return value of setuid/setgid >> selftests: safesetid: Fix Makefile to set correct test program > > These 3 fixes look good, thanks. Were you thinking they would go > through my SafeSetID tree or is there a dedicated one for selftests? I > guess if you're not sure someone else on here can chime in, or I can > just take them through my tree if I don't hear anything. > Yes. There is a linux-kselftest tree dedicated to selftests. I can take them. >> >> >> tools/testing/selftests/safesetid/Makefile | 5 +++-- >> tools/testing/selftests/safesetid/safesetid-test.c | 15 ++++++++++----- >> 2 files changed, 13 insertions(+), 7 deletions(-) >> >> -- thanks, -- Shuah