Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 05 Dec 2019 22:55:05 +0530
From:   "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Subject: Re: [PATCH 0/3] pseries: Track and expose idle PURR and SPURR ticks
To:     Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
        Nathan Lynch <nathanl@linux.ibm.com>
Cc:     "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        Michael Ellerman <mpe@ellerman.id.au>,
        Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
        Tyrel Datwyler <tyreld@linux.ibm.com>
References: <1574856072-30972-1-git-send-email-ego@linux.vnet.ibm.com>
        <87r21ju3ud.fsf@linux.ibm.com>
        <48823589-b105-0da3-e532-f633ade8f0d9@linux.vnet.ibm.com>
        <87k17au4rw.fsf@linux.ibm.com>
In-Reply-To: <87k17au4rw.fsf@linux.ibm.com>
MIME-Version: 1.0
User-Agent: astroid/v0.15-13-gb675b421
 (https://github.com/astroidmail/astroid)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8BIT
Message-Id: <1575566328.nhfi897fmd.naveen@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Nathan,

Nathan Lynch wrote:
> Hi Kamalesh,
> 
> Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> writes:
>> On 12/5/19 3:54 AM, Nathan Lynch wrote:
>>> "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> writes:
>>>>
>>>> Tools such as lparstat which are used to compute the utilization need
>>>> to know [S]PURR ticks when the cpu was busy or idle. The [S]PURR
>>>> counters are already exposed through sysfs.  We already account for
>>>> PURR ticks when we go to idle so that we can update the VPA area. This
>>>> patchset extends support to account for SPURR ticks when idle, and
>>>> expose both via per-cpu sysfs files.
>>> 
>>> Does anything really want to use PURR instead of SPURR? Seems like we
>>> should expose only SPURR idle values if possible.
>>> 
>>
>> lparstat is one of the consumers of PURR idle metric
>> (https://groups.google.com/forum/#!topic/powerpc-utils-devel/fYRo69xO9r4). 
>> Agree, on the argument that system utilization metrics based on SPURR
>> accounting is accurate in comparison to PURR, which isn't proportional to
>> CPU frequency.  PURR has been traditionally used to understand the system
>> utilization, whereas SPURR is used for understanding how much capacity is
>> left/exceeding in the system based on the current power saving mode.
> 
> I'll phrase my question differently: does SPURR complement or supercede
> PURR? You seem to be saying they serve different purposes. If PURR is
> actually useful rather then vestigial then I have no objection to
> exposing idle_purr.

SPURR complements PURR, so we need both. SPURR/PURR ratio helps provide 
an indication of the available headroom in terms of core resources, at 
maximum frequency.


- Naveen