Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 5 Dec 2019 10:44:50 -0800
From:   Paul Burton <paulburton@kernel.org>
To:     Alexander Lobakin <alobakin@dlink.ru>
Cc:     Paul Burton <paul.burton@mips.com>,
        Hassan Naveed <hnaveed@wavecomp.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        James Hogan <jhogan@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        Andrii Nakryiko <andriin@fb.com>, netdev@vger.kernel.org,
        bpf@vger.kernel.org, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: MIPS eBPF JIT support on pre-32R2
Message-ID: <20191205184450.lbrkenmursz4zpdm@lantea.localdomain>
References: <09d713a59665d745e21d021deeaebe0a@dlink.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <09d713a59665d745e21d021deeaebe0a@dlink.ru>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Alexander,

On Thu, Dec 05, 2019 at 03:45:27PM +0300, Alexander Lobakin wrote:
> Hey all,
> 
> I'm writing about lines arch/mips/net/ebpf_jit.c:1806-1807:
> 
> 	if (!prog->jit_requested || MIPS_ISA_REV < 2)
> 		return prog;
> 
> Do pre-32R2 architectures (32R1, maybe even R3000-like) actually support
> this eBPF JIT code?

No, they don't; the eBPF JIT makes unconditional use of at least the
(d)ins & (d)ext instructions which were added in MIPSr2, so it would
result in reserved instruction exceptions & panics if enabled on
pre-MIPSr2 CPUs.

> If they do, then the condition 'MIPS_ISA_REV < 2'
> should be removed as it is always true for them and tells CC to remove
> JIT completely.
> 
> If they don't support instructions from this JIT, then the line
> arch/mips/Kconfig:50:
> 
> 	select HAVE_EBPF_JIT if (!CPU_MICROMIPS)
> 
> should be changed to something like:
> 
> 	select HAVE_EBPF_JIT if !CPU_MICROMIPS && TARGET_ISA_REV >= 2
> 
> (and then the mentioned 'if' condition would become redundant)

Good spot; I agree entirely, this dependency should be reflected in
Kconfig.

> At the moment it is possible to build a kernel without both JIT and
> interpreter, but with CONFIG_BPF_SYSCALL=y (what should not be allowed
> I suppose?) within the following configuration:
> 
> - select any pre-32R2 CPU (e.g. CONFIG_CPU_MIPS32_R1);
> - enable CONFIG_BPF_JIT (CONFIG_MIPS_EBPF_JIT will be autoselected);
> - enable CONFIG_BPF_JIT_ALWAYS_ON (this removes BPF interpreter from
>   the system).
> 
> I may prepare a proper patch by myself if needed (after clarification).

That would be great, thanks!

One thing to note is that I hope we'll restore the cBPF JIT with this
patch:

https://lore.kernel.org/linux-mips/20191205182318.2761605-1-paulburton@kernel.org/T/#u

The cBPF JIT looks like it should work on older pre-MIPSr2 CPUs, so the
only way this is relevant is that your patch might have a minor
conflict. But I thought I'd mention it anyway :)

Thanks,
    Paul