Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Parav Pandit <parav@mellanox.com>
To:     Chuhong Yuan <hslester96@gmail.com>
CC:     Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] RDMA/cma: add missed unregister_pernet_subsys in init
 failure
Thread-Topic: [PATCH] RDMA/cma: add missed unregister_pernet_subsys in init
 failure
Thread-Index: AQHVq4X+uZCTp3HGm0yAWTgo2WdDwaer4g5w
Date:   Thu, 5 Dec 2019 18:49:58 +0000
Message-ID: <AM0PR05MB486638F7997D643FAD64B482D15C0@AM0PR05MB4866.eurprd05.prod.outlook.com>
References: <20191205160632.32132-1-hslester96@gmail.com>
In-Reply-To: <20191205160632.32132-1-hslester96@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 70c08c0a-fbb7-49a4-57f4-08d779b3ed95
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2019 18:49:58.7469
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZCTPfvtrtJCOD51xShImtjP2qFBRU2AbQ4t1QS3bjMyQWVSf5CU/T+OUkRMSu9eAEs7z/UhfccuvSc8+8n/cbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4756
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> From: linux-kernel-owner@vger.kernel.org <linux-kernel-
> owner@vger.kernel.org> On Behalf Of Chuhong Yuan
> Sent: Thursday, December 5, 2019 10:07 AM
> The driver forgets to call unregister_pernet_subsys() in the error path o=
f
> cma_init().
> Add the missed call to fix it.
>=20
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
>  drivers/infiniband/core/cma.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.=
c
> index 25f2b70fd8ef..43a6f07e0afe 100644
> --- a/drivers/infiniband/core/cma.c
> +++ b/drivers/infiniband/core/cma.c
> @@ -4763,6 +4763,7 @@ static int __init cma_init(void)
>  err:
>  	unregister_netdevice_notifier(&cma_nb);
>  	ib_sa_unregister_client(&sa_client);
> +	unregister_pernet_subsys(&cma_pernet_operations);
>  err_wq:
>  	destroy_workqueue(cma_wq);
>  	return ret;
> --
> 2.24.0
Please add to commit log.

Fixes: 4be74b42a6d0 ("IB/cma: Separate port allocation to network namespace=
s ")=20

Reviewed-by: Parav Pandit <parav@mellanox.com>