Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2151765ybl; Thu, 5 Dec 2019 13:00:29 -0800 (PST) X-Google-Smtp-Source: APXvYqyVYinlBsY36NNRd347TG/i/1csHdrlTJo666OREf0X3Uk8jlwwlRlqyOF3C4anGlZaD63a X-Received: by 2002:aca:f516:: with SMTP id t22mr9502045oih.34.1575579628900; Thu, 05 Dec 2019 13:00:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575579628; cv=none; d=google.com; s=arc-20160816; b=myS/tI73QPNPrd41smcD9Zsd/SF19hIyst+T2ifTe+E/mOpU1Mje4FxT2AHUsb1i3p ygWmdB9czB04XNgZp82t8ZwBqe3KrSgJxGwUB9FdWl3IY+Kf5eyXAqtIJ2H7FSjYN7Oh iRC/pvvbIWMwzAmPXCuv63V50pNu0XplxPyMzRFXCR/AWAlGq3/8lNDM99DZTFZ8SHiQ hszCPsALcYpJbUInoklr4s0CcIe9oYc4FGtYlhBsOgWNNqflGAbX7wzLhxrgNSOUGL2I MzGUEUnPwEOxwx3cjT4fY13hTHQqr10jzDAP3iZVOUWsD9WZ4eOSfXl19PmRmLXStOZ6 eDWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=GbqjKH8YsKnW/N3x6Qpx0YEAwoifburiSHjzAMeEXSg=; b=OR3XR3hdFGewqiv+tZ/2Hq2hDZ/2Y+bS2xPv47vdrjqRASWnEX3rGe8jP1a/jR/xmS KJRRP7AOSVhsbiShPMB2LWWHTIGliVEKN7HD2VRZYzW2ccxlj1HUvD62tyDUfNNRGcXB EQh1/zIHtGLnXJ3cMPr0QjFbDqv9+NSynheWftIwxRFuvPINl2RgdXefZ7NmsYF0PbBA UGLIIgWREcrGUHYin2yd9KjHIPIs3lXaZf8ao3TUbe/YUCiahIFSyqAhFIQ5hxZv9D/M M3OUq+k21rjTm6/I25ieF8WWcJeIsxgpE82JQLAMsr7Bu184Y+qoyi3KgPj9KZJToGDK tzwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=AmlfDNrL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x189si5476021oig.188.2019.12.05.13.00.14; Thu, 05 Dec 2019 13:00:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=AmlfDNrL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731109AbfLEU7m (ORCPT + 99 others); Thu, 5 Dec 2019 15:59:42 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:36690 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731085AbfLEU7l (ORCPT ); Thu, 5 Dec 2019 15:59:41 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id xB5KxUNi054523; Thu, 5 Dec 2019 14:59:30 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1575579570; bh=GbqjKH8YsKnW/N3x6Qpx0YEAwoifburiSHjzAMeEXSg=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=AmlfDNrL7P3G3IBt/RgKKVFZKcVF06+vhDiDD85phTg95uGuFNezljJg2xa6IIP6S CAeRmH68TY+7T/0OGjQyCb9E/LgHPHSgimnZ8q0xj1HiFp4G+gDF5fbyflN+0rhoRG joDxO1KmAjsiFftZWCYChc5MSLaaspmNzWxFa0Ac= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id xB5KxUl0040632; Thu, 5 Dec 2019 14:59:30 -0600 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Thu, 5 Dec 2019 14:59:30 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Thu, 5 Dec 2019 14:59:30 -0600 Received: from [10.250.65.13] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id xB5KxUVW129738; Thu, 5 Dec 2019 14:59:30 -0600 Subject: Re: [PATCH 0/2] can: m_can_platform: Bug fix of kernel panic for To: Pankaj Sharma , , , CC: , , , , References: <1574158838-4616-1-git-send-email-pankj.sharma@samsung.com> From: Dan Murphy Message-ID: Date: Thu, 5 Dec 2019 14:57:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <1574158838-4616-1-git-send-email-pankj.sharma@samsung.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pankaj On 11/19/19 4:20 AM, Pankaj Sharma wrote: > The current code is failing while clock prepare enable because of not > getting proper clock from platform device. > A device driver for CAN controller hardware registers itself with the > Linux network layer as a network device. So, the driver data for m_can > should ideally be of type net_device. > > Further even when passing the proper net device in probe function the > code was hanging because of the function m_can_runtime_resume() getting > recursively called from m_can_class_resume(). > > Pankaj Sharma (2): > can: m_can_platform: set net_device structure as driver data > can: m_can_platform: remove unnecessary m_can_class_resume() call Did you CC: linux-stable for these?  We are probably going to have customers picking up 5.4 LTS and would need these bug fixes. Or at the very least see if the stable automation will pick these up. Dan