Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp175346ybl; Thu, 5 Dec 2019 17:26:14 -0800 (PST) X-Google-Smtp-Source: APXvYqxNLyNKH6fdsx/wWUoBxBbcKCv6+5uu9hA/X9onh/uoa+IFDQojR3KfT/qS5Nhs4Q+HMzv4 X-Received: by 2002:a54:440d:: with SMTP id k13mr10425466oiw.128.1575595574468; Thu, 05 Dec 2019 17:26:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575595574; cv=none; d=google.com; s=arc-20160816; b=ImRcTtNefpfIRSoUu9RYu5fk9Rve+Eofsq52rTxGD7eP7y94VgvK0EoBSdiNvhRcTa SbXMVPjxxjdyLM0xbRQn8pE2Rw6PQnafBCy/IJ7dLqQZXZ8T1By5hhv4EHRAC8pnIxYb M7qFbAsxf6DAAzIkAGoHRP4QzaNv8IU+9+CbbpoDZotY9WlMJlqqkV8jBywiYEl3xJ/w 9aK4oPw8wXwEQ8c/vYfuLR00aQd4epniv87Y9tQ5om/oltSf4WdQRebBDowsQxsRXsD9 8X0JC2kMiPjFizAmsC/iVtslpi28ovQiJJBIF0saBcAsA9pVCHlZv/+t+0SeJnQdt/S4 kWZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=SfjMY47vEQfcTustnu7BvQsjt98VexA2sDEGnIdmTtk=; b=ejE7PumxBGm2OWv1LhDIg+oVzppqdJ8c21VgR2yUh/iWQi5i8VWli6MbNNSLoEzgvV omMu74Oi4cfCrgMGzBFEqZ4YaJPTy9wu+BB4h0G3N1hKmwLP7pJMfq1/p8kxsXyGFd9g sUx6XTXyqNcMZt1EyERjhXYdz6tDAghO5dprK9JNPv+36qPvTJxVStOH306HEJFmfUMn WUbuNu8suQ/QaaKy5ze7r/zlxFt1g9TgHSlk2ZwMXQk8ER0ixEUyoLfiSx5A7TjdocbA XttMNtfRYq2KAh3iZG4t1vxovObm4iCa95H6Au9GckzJieyPNSYAZnM0RHWmzbfR/Ckk Cnxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=k8cjoOPv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q6si6155503oti.173.2019.12.05.17.26.00; Thu, 05 Dec 2019 17:26:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=k8cjoOPv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726269AbfLFBXk (ORCPT + 99 others); Thu, 5 Dec 2019 20:23:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:37920 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725959AbfLFBXj (ORCPT ); Thu, 5 Dec 2019 20:23:39 -0500 Received: from devnote2 (unknown [180.22.253.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B3B4020706; Fri, 6 Dec 2019 01:23:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575595419; bh=+snBBNFYQv8xmYqi1k67brmlOE46FSD3M+ydplTWD0k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=k8cjoOPvcX3iBd3/y/6lsJSEI91mBnpHgvQa8SMeOJplIiGkjdxAcKLes6qlLz08v yD1iboa/DygvAy7yPkH4aU54IMmrAf/TFnFAnZuNNVi5y8BvKlvbJaDK2y96AMLR7o h4pFnHjAHA2wgNAUsLjd6zN0L9HszCMEAZAhLx7A= Date: Fri, 6 Dec 2019 10:23:34 +0900 From: Masami Hiramatsu To: shuah Cc: Micah Morton , linux-kselftest@vger.kernel.org, Linux Kernel Mailing List , jaswinder.singh@linaro.org Subject: Re: [BUGFIX PATCH v2 0/3] selftests: safesetid: Fix some bugs in safesetid test Message-Id: <20191206102334.35f578b1e79e57740e56a5b8@kernel.org> In-Reply-To: <3bad79d5-eada-7e96-4210-c4888bfb710f@kernel.org> References: <157554844882.11018.13436399905210284553.stgit@devnote2> <3bad79d5-eada-7e96-4210-c4888bfb710f@kernel.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Dec 2019 09:44:52 -0700 shuah wrote: > On 12/5/19 9:40 AM, Micah Morton wrote: > > On Thu, Dec 5, 2019 at 4:20 AM Masami Hiramatsu wrote: > >> > >> Hi, > >> > >> Here is the v2 series to fix build warnings and erorrs on > >> kselftest safesetid. > >> This version includes a fix for a runtime error. > >> > >> Thank you, > >> > >> --- > >> > >> Masami Hiramatsu (3): > >> selftests: safesetid: Move link library to LDLIBS > >> selftests: safesetid: Check the return value of setuid/setgid > >> selftests: safesetid: Fix Makefile to set correct test program > > > > These 3 fixes look good, thanks. Were you thinking they would go > > through my SafeSetID tree or is there a dedicated one for selftests? I > > guess if you're not sure someone else on here can chime in, or I can > > just take them through my tree if I don't hear anything. > > > > Yes. There is a linux-kselftest tree dedicated to selftests. > I can take them. Thanks Micah and Shuah! > > > >> > >> > >> tools/testing/selftests/safesetid/Makefile | 5 +++-- > >> tools/testing/selftests/safesetid/safesetid-test.c | 15 ++++++++++----- > >> 2 files changed, 13 insertions(+), 7 deletions(-) > >> > >> -- > > thanks, > -- Shuah > -- Masami Hiramatsu