Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <833788ce05014084af1e6160fb81e5cd@huawei.com>
In-Reply-To: <833788ce05014084af1e6160fb81e5cd@huawei.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Fri, 6 Dec 2019 11:10:32 +0800
Message-ID: <CANRm+CyOxq9S4pjcGzjuTdE+Vp8H+oq3JezihV3CRm8XFXc-ww@mail.gmail.com>
Subject: Re: [PATCH] KVM: vmx: remove unreachable statement in vmx_get_msr_feature()
To:     linmiaohe <linmiaohe@huawei.com>
Cc:     Liran Alon <liran.alon@oracle.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "rkrcmar@redhat.com" <rkrcmar@redhat.com>,
        "sean.j.christopherson@intel.com" <sean.j.christopherson@intel.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "wanpengli@tencent.com" <wanpengli@tencent.com>,
        "jmattson@google.com" <jmattson@google.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 6 Dec 2019 at 09:54, linmiaohe <linmiaohe@huawei.com> wrote:
>
> >
> >I personally just prefer to remove the =E2=80=9Cdefault=E2=80=9D case an=
d change this =E2=80=9Creturn 0;=E2=80=9D to =E2=80=9Creturn 1;=E2=80=9D.
> >But it=E2=80=99s a matter of taste of course.
> >
> Yes. As what " Turnip greens, all have love " said. ^_^

Actually it is a great appreciated to introduce something more useful
instead of tons of cleanups, I saw guys did one cleanup and can incur
several bugs before.

    Wanpeng