Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp421674ybl; Thu, 5 Dec 2019 23:30:50 -0800 (PST) X-Google-Smtp-Source: APXvYqxyCM/9naoi5NFlMcTDD8+cqXZHIfVxWVYetSJsv0Mh9kKVJJqPMBXMJ29hpHuJKXWqZOQr X-Received: by 2002:a54:401a:: with SMTP id x26mr11100230oie.15.1575617450065; Thu, 05 Dec 2019 23:30:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575617450; cv=none; d=google.com; s=arc-20160816; b=QDEKpLyi1EhYJuSeqTFTPc5/W+Pm1J7numhXtz1ZaTGbW338qeJEIPz9bHY0IWMuTB ZCkI0HTcAv+T+2hRtucxFxPJCcyphZjhN0Bh+fBIfLenikjNFBPtb8D3ialtLMGVoxsA 6KC05DvAHcWFKyEqnunFrE1VbVoNMu3iralGG8BFCIH+rVzkKuAuzJbEwxOUvruhr8+y y1V9PA5Dq9fH8b4qcu5vGivtIB9uEJFuJxxgfg0hbqP8tOP/bP9JWkgk7ySlpBaaDIEw zndHwooppc28ZPkIqLXwHUHWqzbt5PiIRrgGMg4tMyKVrvZUEuHHS4K6DH9sv86c0Yqe XGhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from; bh=KOIV5hBdFuSOFco9oZ5NgEJsUiqiGqrre0vJmXKwvKY=; b=B1PG26V/VVV8He/Ox9sQjMmjBNYCrDLCyN8aTbG8GWR4LC59pYgXBIvikX6rWYc691 z+BaGTMme2mDbqk7vX1HyBgtzYxU+dWfA08iUa/gf00ytQc2ZpODaeRPRj0/uzaqh9eV DOW+WEdJMD2CBTttH7ULqEZciXgNYFnOq/xPQ2DttSK8+EWV/D6v8k+lJWr7OKzYdAFc 6IaBm9e305WY2mM7MCcv8Ni6Y9BH2Wrtahzls33ObT9fhr2+yuWDI9eOad9HlmukZqPO Uo8EP/mJjCKFbe4hfspU1co5kUfTWu+BHKTHU3Zyzgg3RAk626RldZKdgH3gBfF9qzqM McyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d8si6410328otl.83.2019.12.05.23.30.36; Thu, 05 Dec 2019 23:30:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726551AbfLFH2O (ORCPT + 99 others); Fri, 6 Dec 2019 02:28:14 -0500 Received: from mga17.intel.com ([192.55.52.151]:48024 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726472AbfLFH2K (ORCPT ); Fri, 6 Dec 2019 02:28:10 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2019 23:28:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,283,1571727600"; d="scan'208";a="263519920" Received: from sgsxdev004.isng.intel.com (HELO localhost) ([10.226.88.13]) by FMSMGA003.fm.intel.com with ESMTP; 05 Dec 2019 23:28:06 -0800 From: Dilip Kota To: lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, andriy.shevchenko@intel.com Cc: gustavo.pimentel@synopsys.com, andrew.murray@arm.com, robh@kernel.org, linux-kernel@vger.kernel.org, cheol.yong.kim@intel.com, chuanhua.lei@linux.intel.com, qi-ming.wu@intel.com, Dilip Kota Subject: [PATCH v10 3/3] PCI: artpec6: Configure FTS with dwc helper function Date: Fri, 6 Dec 2019 15:27:50 +0800 Message-Id: <0cee553f18a8ec1ae84ee64cdffb6627e4c5bc02.1575612493.git.eswara.kota@linux.intel.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use DesignWare helper functions to configure Fast Training Sequence. Drop the respective code in the driver. Signed-off-by: Dilip Kota Signed-off-by: Lorenzo Pieralisi Reviewed-by: Andrew Murray --- Changes on v10: No change. drivers/pci/controller/dwc/pcie-artpec6.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-artpec6.c b/drivers/pci/controller/dwc/pcie-artpec6.c index d00252bd8fae..02d93b8c7942 100644 --- a/drivers/pci/controller/dwc/pcie-artpec6.c +++ b/drivers/pci/controller/dwc/pcie-artpec6.c @@ -51,9 +51,6 @@ static const struct of_device_id artpec6_pcie_of_match[]; #define ACK_N_FTS_MASK GENMASK(15, 8) #define ACK_N_FTS(x) (((x) << 8) & ACK_N_FTS_MASK) -#define FAST_TRAINING_SEQ_MASK GENMASK(7, 0) -#define FAST_TRAINING_SEQ(x) (((x) << 0) & FAST_TRAINING_SEQ_MASK) - /* ARTPEC-6 specific registers */ #define PCIECFG 0x18 #define PCIECFG_DBG_OEN BIT(24) @@ -313,10 +310,7 @@ static void artpec6_pcie_set_nfts(struct artpec6_pcie *artpec6_pcie) * Set the Number of Fast Training Sequences that the core * advertises as its N_FTS during Gen2 or Gen3 link training. */ - val = dw_pcie_readl_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL); - val &= ~FAST_TRAINING_SEQ_MASK; - val |= FAST_TRAINING_SEQ(180); - dw_pcie_writel_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL, val); + dw_pcie_link_set_n_fts(pci, 180); } static void artpec6_pcie_assert_core_reset(struct artpec6_pcie *artpec6_pcie) -- 2.11.0