Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp453907ybl; Fri, 6 Dec 2019 00:14:48 -0800 (PST) X-Google-Smtp-Source: APXvYqxQH40zPJmN9Z0O0DXa1vgwrPhrVXTwbMV4LcOh5wB22Ou+Vd1OynU44PkzgmfoNsJhMVFw X-Received: by 2002:aca:4850:: with SMTP id v77mr8983891oia.70.1575620088446; Fri, 06 Dec 2019 00:14:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575620088; cv=none; d=google.com; s=arc-20160816; b=RrAPQ21WujAhxsjqSdlyZnZFgDrSBdidxzpeA5xR51ymbZDvfVlCm9TFTKq5EAQf9/ +kCyxafa4M2PszU4i178w/iJalXiA7egAoaw8A1lqbpx8DAohb/nGsEtRZAx6uiDxfk2 64ulrxT1EHMQ7oK11nBuan6gSx71JEzqoILtK4gj2VCK9MYo/uOq3iA/pxPSnvsKzcYO FGRUgC+MRE6lqzLh42SCbqsjCGOBcV9sUWntLaKItfweTkwTIPRqzGiPb5q0afoFILb0 YS3EhGeJ3r2T/OQjTMLBN2yVoVH97xpLDtKpRZrhwaqDg0AGzLxHTRGthTToZ4hqHh0S cmfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=4QO+ulCytfHgL7qVYv09QqcQL+hLC3saTPny9UiLdvA=; b=iQLzvktS595TFgCBCVes6/IXFm69mKQEjzPMQnTR0CGIV7K4vldJHB8Bjw/KY7CFyl thap0zOif9hJGsAvh9eOaxRi+IhrhGEwnHnNShAoBEe90bEKLbPodF8Carp0T4QRp9ro r6WXzI/jKcFj5oBHHlHol9l8JXwH4BJHjamSTcQpsmAIOq3/eCpOvUOHu6nZ755/83h1 GZISx64eR2bvJU2YhDAM/yE9dYE92g1IMbeNgOaL5wFXqYcyPtBnHf0qqaAqulNNfbuQ WmuqrOE/hcDbnkM4xSeeCKx3jiRC/wUvtHn+5Ntl6FvlRkpJld4Padg5Df8sR/RYEukl 5jNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=qN1H8LBY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v18si6560426oic.27.2019.12.06.00.14.36; Fri, 06 Dec 2019 00:14:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=qN1H8LBY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726413AbfLFHxM (ORCPT + 99 others); Fri, 6 Dec 2019 02:53:12 -0500 Received: from mail-pj1-f68.google.com ([209.85.216.68]:35480 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726184AbfLFHxM (ORCPT ); Fri, 6 Dec 2019 02:53:12 -0500 Received: by mail-pj1-f68.google.com with SMTP id w23so2410809pjd.2 for ; Thu, 05 Dec 2019 23:53:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4QO+ulCytfHgL7qVYv09QqcQL+hLC3saTPny9UiLdvA=; b=qN1H8LBYbMmKIwNlI9yzqDRW2TyamGui3efbW/hiY6qegMZI6tvwZsels63TUNqDov ky6rAXJvi3QSSPnrul01cUfqF4sZ1EsVtg4L9+2Pdb7ZFuxVWaC8d73ezcr9Hrd8HkHG hW6zIFeDgEuxBWuYxYSqVkJWySSRbst0ZJIkdPyTo/NKNuzjhRJvK4A2KQoxf6IdJozY ee5KlI8s4ccDDP/OnlUDWkZ/Nxr49cFZZDaRdxxU9FL+9BpPuJQXedzcXL3sMqzhIeWV gKL4O/IY2wSfy5HAizvO7JByJiaNqqFIHP6bE7e88PeEUK5hVmCodAsiNNCWZIudtCRa juEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4QO+ulCytfHgL7qVYv09QqcQL+hLC3saTPny9UiLdvA=; b=XnwZ0O5O1S7qi6aWtf1BNJdHFgFme8sqx+0VI4RxrwYUWWyiJEhKlpRqrDXGkqMDeE tB324PwSqmI+x+I2a6UOm0t9PeYe3s1pRbpUwbJqsnuVrixVRucthlWlVtFch9fI72Kz l+bYk9lkhB/kSo7CGCLsm3vipwdXMd4UKqvY/yg54e6fcZsYHL23cC4JfSkS1BeaeaB1 4ZQW0Oi4IcdIFk5uCQqeWAlekA22WSPQTbpFNY96i1mCdpvS2KOojG6NHH7WoF/bZ1xY CmBYsVp7o31S62D5ywzv9ayMfyt1zvvUkSzoTE1OEio98TznnwMrvDq3OeVBJQuoWMbi rkAg== X-Gm-Message-State: APjAAAWws5b9CxSH5ey0JqtqYifchcN9VgPjzm7Gr6D5zp3vbVzp5KqQ 64iUt7OMKhIJ1Zc3R/pGh5k= X-Received: by 2002:a17:902:9682:: with SMTP id n2mr13035545plp.336.1575618791691; Thu, 05 Dec 2019 23:53:11 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id h68sm15999256pfe.162.2019.12.05.23.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2019 23:53:11 -0800 (PST) From: Chuhong Yuan Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH] ASoC: wm5100: add missed regulator_bulk_disable Date: Fri, 6 Dec 2019 15:53:00 +0800 Message-Id: <20191206075300.18182-1-hslester96@gmail.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver forgets to call regulator_bulk_disable() in remove like that in probe failure. Add the missed call to fix it. Signed-off-by: Chuhong Yuan --- sound/soc/codecs/wm5100.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c index 91cc63c5a51f..d985b2061169 100644 --- a/sound/soc/codecs/wm5100.c +++ b/sound/soc/codecs/wm5100.c @@ -2653,6 +2653,8 @@ static int wm5100_i2c_remove(struct i2c_client *i2c) gpio_set_value_cansleep(wm5100->pdata.ldo_ena, 0); gpio_free(wm5100->pdata.ldo_ena); } + regulator_bulk_disable(ARRAY_SIZE(wm5100->core_supplies), + wm5100->core_supplies); return 0; } -- 2.24.0