Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] x86/fpu: Warn only when CPU-provided sizes less than
 struct declaration
To:     Dave Hansen <dave.hansen@intel.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
        jon.grimm@amd.com,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Thomas Lendacky <Thomas.Lendacky@amd.com>
References: <1575363688-36727-1-git-send-email-suravee.suthikulpanit@amd.com>
 <b63e2111-b0c6-a716-3d99-88f91ad64e1d@intel.com>
From:   Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Message-ID: <68bdd6f0-a229-433a-9234-303a3b02b092@amd.com>
Date:   Fri, 6 Dec 2019 15:14:13 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0)
 Gecko/20100101 Thunderbird/68.2.2
In-Reply-To: <b63e2111-b0c6-a716-3d99-88f91ad64e1d@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-CrossTenant-Network-Message-Id: 960911e4-9b0f-4d6c-b3e3-08d77a244fcd
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2019 08:14:27.6724
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HUdB09LFjQU8KOVxLoFaieINI5Whcs9QhOsEIQQqp910gGDEGsSFe6v8aPifhNZ6hlJFaZWyv35EwdkquKlo9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3324
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Dave,

On 12/4/19 12:27 AM, Dave Hansen wrote:
> On 12/3/19 1:01 AM, Suravee Suthikulpanit wrote:
>> The current XCHECK_SZ macro warns if the XFEATURE size reported
>> by CPUID does not match the size of kernel structure. However, depending
>> on the hardware implementation, CPUID can report the XSAVE state size
>> larger than the size of C structures defined for each of the XSAVE state
>> due to padding.
> 
> We have existing architecture for padding.  See xfeature_is_aligned(),
> for instance.  Are you saying that there are implementations out there
> that do padding which is not otherwise enumerated and that they do it
> within the size of the enumerated stat
Yes, the implementation includes the padding size within the size of
the enumerated state. This results in the reported size larger than
the amount needed by the feature.

>> Such case should be safe and should not need to generate warning
>> message.
> 
> I've seen these error messages trip before, but only on pre-production
> processors with goofy microcode.  I'd be really suspicious that this is
> just papering over a processor issue.  Or, that perhaps the compacted
> form works but the standard form is broken somehow.

I have verified with the HW folks and the have confirmed that this is
to be expected.

Thanks,
Suravee