Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] KVM: vmx: remove unreachable statement in
 vmx_get_msr_feature()
To:     linmiaohe <linmiaohe@huawei.com>, Wanpeng Li <kernellwp@gmail.com>
Cc:     Liran Alon <liran.alon@oracle.com>,
        "rkrcmar@redhat.com" <rkrcmar@redhat.com>,
        "sean.j.christopherson@intel.com" <sean.j.christopherson@intel.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "wanpengli@tencent.com" <wanpengli@tencent.com>,
        "jmattson@google.com" <jmattson@google.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
References: <6c7423896f6f49f2a2b439afe809db08@huawei.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <f7b20a96-0b75-32a4-0448-30c6061fc6cb@redhat.com>
Date:   Fri, 6 Dec 2019 10:58:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <6c7423896f6f49f2a2b439afe809db08@huawei.com>
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 06/12/19 04:41, linmiaohe wrote:
> Wanpeng Li <kernellwp@gmail.com> wrote:
>>>
>>>>
>>>> I personally just prefer to remove the =E2=80=9Cdefault=E2=80=9D case =
and change this =E2=80=9Creturn 0;=E2=80=9D to =E2=80=9Creturn 1;=E2=80=9D.
>>>> But it=E2=80=99s a matter of taste of course.
>>>>
>>> Yes. As what " Turnip greens, all have love " said. ^_^
>>
>> Actually it is a great appreciated to introduce something more useful in=
stead of tons of cleanups, I saw guys did one cleanup and can incur several=
 bugs before.
>>
> I'd like to introduce something more useful, but side corner cleanups may=
 be hard to
> found out something to introduce. And such cleanups can also be validated=
 by code inspection
> to avoid something bad. Many thanks.
>=20

Yeah, I think you have been doing a good job.  Usually, when the
cleanups introduce bugs there are many other "suspicious" things.  For
me it's clear that you're learning the code and not just messing around.

Paolo