Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp542103ybl; Fri, 6 Dec 2019 02:08:35 -0800 (PST) X-Google-Smtp-Source: APXvYqywg4F8unURIIjXR+Lig3RtZqNca7gT49px0Wju+PcD2LJ57Kpm3rEuKJfg+SD1y7EFCYKU X-Received: by 2002:aca:b344:: with SMTP id c65mr11782074oif.88.1575626915228; Fri, 06 Dec 2019 02:08:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575626915; cv=none; d=google.com; s=arc-20160816; b=i6i9JX6N0absHnLxSjiPWodM55iXyNAXXMv0QJx7kk5WFqQ81YJ5ziZzsfFtq9vMXt e9QllwyBXXoGRF7A6M6eM0q37XTKUGRzqXmDWLXC0cimJbLxCbkr3k3dkALYUTzLdbpf xaFl2r8LS+HWOPF8kDBzi7ZfbV3J0cumZql7c/8R70xoa0aQQGdL65OsYKdrsFHY80WI AIBeHojdGBuqnxOYyfZ55qsZKVT9BDGNNQ6w3ofk0x9WedkI2olhPZPVzSSm8qbI/E15 sZi847xuE6xH9uCoWPAj/d+IsxkBOU6xj6OYywmJzs2DrDp2mM2FjpXACEL6I9oO9D7O z4Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:in-reply-to:mime-version:references :message-id:subject:to:from:date:dkim-signature; bh=Wc1Uv6Nj7IUv6CX0rM0U3pEdROrdD6V3JPm9xjrxf2s=; b=h3RWu9koWvk0DRKZxhB/fStsK0w05cs1evDv7EgDblAaM45P4xghs2acxzb2+8ZrOZ UM4XpM/7xh4jqIVPiw+XAWgEumN6adNI+5dEJH7AyzZh8SLcJllq8PxDzCgG9rbNb4f0 g3E52Z8dsdsnGwmyVJY1SCEzF/9uxDFOUNT/JDoucVVz1MC3cWL6nCaURENbVOTK42wE thdcRco05T3txq0OEm13eQf19/IC2tGx9PAP2f+5C3mS8TsMBEu+yjIrX+Z8awbdCIcx bYQGfvo8b8rm8qIVB9fAqKQpHeaHDFxlYLZ4rYCyTmiQllq0I2hEX3tLNZAwjEhKbWcM fIMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BxzFDejE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x207si6704014oif.30.2019.12.06.02.08.22; Fri, 06 Dec 2019 02:08:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BxzFDejE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726245AbfLFKHc (ORCPT + 99 others); Fri, 6 Dec 2019 05:07:32 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:53899 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726102AbfLFKHc (ORCPT ); Fri, 6 Dec 2019 05:07:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575626851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wc1Uv6Nj7IUv6CX0rM0U3pEdROrdD6V3JPm9xjrxf2s=; b=BxzFDejEJcZGsF+SZFlnJqQBxChvKaJufogYLXDJpYE8SE4bSRnifFpRBHMXR5rmBJWO6F ZuSPbCg7G43avF54j7npeaMccQI9PHIqQhx3bZa9ZDkabdi7Gyvu+iQhRogaeBK68IaFYB fx1+XNJI9EeeT846TYSM0vSNFaJdUDY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-255-CmzEfi7tP9evyYLm71Htdg-1; Fri, 06 Dec 2019 05:07:28 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E96A0107ACC4; Fri, 6 Dec 2019 10:07:25 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-67.ams2.redhat.com [10.36.116.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id A4CD15D6A3; Fri, 6 Dec 2019 10:07:25 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id D155616E18; Fri, 6 Dec 2019 11:07:24 +0100 (CET) Date: Fri, 6 Dec 2019 11:07:24 +0100 From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org, robh@kernel.org, intel-gfx@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , David Airlie , Christian Koenig , Huang Rui , open list Subject: Re: [PATCH v3 1/2] drm: call drm_gem_object_funcs.mmap with fake offset Message-ID: <20191206100724.ukzdyaym3ltcyfaa@sirius.home.kraxel.org> References: <20191127092523.5620-1-kraxel@redhat.com> <20191127092523.5620-2-kraxel@redhat.com> <20191128113930.yhckvneecpvfhlls@sirius.home.kraxel.org> <20191205221523.GN624164@phenom.ffwll.local> MIME-Version: 1.0 In-Reply-To: <20191205221523.GN624164@phenom.ffwll.local> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: CmzEfi7tP9evyYLm71Htdg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 05, 2019 at 11:15:23PM +0100, Daniel Vetter wrote: > On Thu, Nov 28, 2019 at 12:39:30PM +0100, Gerd Hoffmann wrote: > > On Wed, Nov 27, 2019 at 10:25:22AM +0100, Gerd Hoffmann wrote: > > > The fake offset is going to stay, so change the calling convention fo= r > > > drm_gem_object_funcs.mmap to include the fake offset. Update all use= rs > > > accordingly. > > >=20 > > > Note that this reverts 83b8a6f242ea ("drm/gem: Fix mmap fake offset > > > handling for drm_gem_object_funcs.mmap") and on top then adds the fak= e > > > offset to drm_gem_prime_mmap to make sure all paths leading to > > > obj->funcs->mmap are consistent. > > >=20 > > > v3: move fake-offset tweak in drm_gem_prime_mmap() so we have this co= de > > > only once in the function (Rob Herring). > >=20 > > Now this series fails in Intel CI. Can't see why though. The > > difference between v2 and v3 is just the place where vma->vm_pgoff gets > > updated, and no code between the v2 and v3 location touches vma ... >=20 > Looks like unrelated flukes, this happens occasionally. If you're paranoi= d > hit the retest button on patchwork to double-check. > -Daniel Guess you kicked CI? Just got CI mails, now reporting success, without doing anything. So I'll go push v3 to misc-next. cheers, Gerd