Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191127092523.5620-1-kraxel@redhat.com> <20191127092523.5620-2-kraxel@redhat.com>
 <20191128113930.yhckvneecpvfhlls@sirius.home.kraxel.org> <20191205221523.GN624164@phenom.ffwll.local>
 <20191206100724.ukzdyaym3ltcyfaa@sirius.home.kraxel.org>
In-Reply-To: <20191206100724.ukzdyaym3ltcyfaa@sirius.home.kraxel.org>
From:   Daniel Vetter <daniel@ffwll.ch>
Date:   Fri, 6 Dec 2019 11:18:34 +0100
Message-ID: <CAKMK7uH==kE_ViKioJgpDRqFq-ROhws7atwwxcmu=Bwt9ZF52Q@mail.gmail.com>
Subject: Re: [Intel-gfx] [PATCH v3 1/2] drm: call drm_gem_object_funcs.mmap
 with fake offset
To:     Gerd Hoffmann <kraxel@redhat.com>
Cc:     dri-devel <dri-devel@lists.freedesktop.org>,
        Rob Herring <robh@kernel.org>,
        intel-gfx <intel-gfx@lists.freedesktop.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        David Airlie <airlied@linux.ie>,
        Christian Koenig <christian.koenig@amd.com>,
        Huang Rui <ray.huang@amd.com>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Dec 6, 2019 at 11:07 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> On Thu, Dec 05, 2019 at 11:15:23PM +0100, Daniel Vetter wrote:
> > On Thu, Nov 28, 2019 at 12:39:30PM +0100, Gerd Hoffmann wrote:
> > > On Wed, Nov 27, 2019 at 10:25:22AM +0100, Gerd Hoffmann wrote:
> > > > The fake offset is going to stay, so change the calling convention for
> > > > drm_gem_object_funcs.mmap to include the fake offset.  Update all users
> > > > accordingly.
> > > >
> > > > Note that this reverts 83b8a6f242ea ("drm/gem: Fix mmap fake offset
> > > > handling for drm_gem_object_funcs.mmap") and on top then adds the fake
> > > > offset to  drm_gem_prime_mmap to make sure all paths leading to
> > > > obj->funcs->mmap are consistent.
> > > >
> > > > v3: move fake-offset tweak in drm_gem_prime_mmap() so we have this code
> > > >     only once in the function (Rob Herring).
> > >
> > > Now this series fails in Intel CI.  Can't see why though.  The
> > > difference between v2 and v3 is just the place where vma->vm_pgoff gets
> > > updated, and no code between the v2 and v3 location touches vma ...
> >
> > Looks like unrelated flukes, this happens occasionally. If you're paranoid
> > hit the retest button on patchwork to double-check.
> > -Daniel
>
> Guess you kicked CI?  Just got CI mails, now reporting success, without
> doing anything.  So I'll go push v3 to misc-next.

Yeah I kicked it, since iirc you need your patchwork account to be
treated with the re-run powers first. Might want to get those with a
quick ping on irc, it's useful.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch