Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp765613ybl; Fri, 6 Dec 2019 05:59:19 -0800 (PST) X-Google-Smtp-Source: APXvYqyD6BUDUHfRtWZKmU2cXL+mfEbaDZNtSpZEduWUw2NvCLZiytg1yIUDHVww8wusUgH6rIRx X-Received: by 2002:a05:6830:1f4d:: with SMTP id u13mr11624965oth.77.1575640759218; Fri, 06 Dec 2019 05:59:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575640759; cv=none; d=google.com; s=arc-20160816; b=kBeyIL8ikQSUWcJ8p5NpvoW2TDCZauypJKfnDAhuu7Q8A9I+F2KCNS8GfI8G5CHef6 N5Du3iIFFpStartdQ+V7ljAMvIucmnxLt1hWFalXweHPtjmZLdfgJ1lOvlvpETjBL2Z5 aei77rgOamnpavgbc0a6/c70uddHfnXoQLl+RmmegKxI6C7Nq2swo747tT+FO0ZglOgy RPYpSRWgPcAsVwhteXfH2ld1DoWAeU/MxqOb4vyxN4DbsK4jIPUjuFrK+rLckE5p5WQo GlhBKb0kkgk6qoGTt2jMKQr07C4NoBm2TVge1LjFFJxnbiqiO39p9Id4tEIlC6PS0vVP 7Rmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=xRQqqnP20hNNA0H/pDP1G9NQ2ppK8LiCIGbchL1PYa4=; b=hURZm6Xt1t1Iu2QwvTLUTyPn8OJSX6HolALEADUWJBFdi+j/6uwQeQkrUIiRycBsyw eU7xC3bWHktI4rMimDZQCHBsOM6uY/uj2amMJCerJrTA0OoNFt6QEgrV93PXmFGT/H5I cLIJtNprjQwkt+/h4x6IG3l1GWnR84oCuH3aMTZ9+GiedLyAIiJCqqXpjSCwoTvCH8sc G32XV8inpqQYhMPiU44hgjVDLRbQl3p9Md/F+8nAjzok+ZdsYueFS+d8QMV0QOA3CBLX W5r7NEAL4LgmzK+IfEU5BdEYZrDu1SRjYLvfumjTaTwtdC8ekEJDA3Wylc+4f+xexF2/ pPdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u144si1116820oia.107.2019.12.06.05.59.07; Fri, 06 Dec 2019 05:59:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726284AbfLFN6g (ORCPT + 99 others); Fri, 6 Dec 2019 08:58:36 -0500 Received: from foss.arm.com ([217.140.110.172]:45418 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726213AbfLFN6f (ORCPT ); Fri, 6 Dec 2019 08:58:35 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4BBEE1FB; Fri, 6 Dec 2019 05:58:35 -0800 (PST) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.197.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6686B3F718; Fri, 6 Dec 2019 05:58:34 -0800 (PST) Date: Fri, 6 Dec 2019 13:58:32 +0000 From: Catalin Marinas To: Heyi Guo Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, wanghaibin.wang@huawei.com, Will Deacon , Mark Rutland Subject: Re: [PATCH] arm64/kernel/entry: refine comment of stack overflow check Message-ID: <20191206135832.GG32767@arrakis.emea.arm.com> References: <20191202113702.34158-1-guoheyi@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191202113702.34158-1-guoheyi@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 02, 2019 at 07:37:02PM +0800, Heyi Guo wrote: > Stack overflow checking can be done by testing > sp & (1 << THREAD_SHIFT) > only for the stacks are aligned to (2 << THREAD_SHIFT) with size of > (1 << THREAD_SIZE), and this is the case when CONFIG_VMAP_STACK is > set. > > Fix the code comment to avoid confusion. > > Signed-off-by: Heyi Guo > Cc: Catalin Marinas > Cc: Will Deacon Queued with Mark's suggested update. -- Catalin