Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191206120735.21873-1-hslester96@gmail.com> <f6fcd441-e92d-0fff-e488-9507999b1682@web.de>
In-Reply-To: <f6fcd441-e92d-0fff-e488-9507999b1682@web.de>
From:   Chuhong Yuan <hslester96@gmail.com>
Date:   Fri, 6 Dec 2019 22:37:08 +0800
Message-ID: <CANhBUQ2p4hkSUgW8ZpA6+M_RsuN72E+v-XN=1a=m-Xf_++ZkdQ@mail.gmail.com>
Subject: Re: [PATCH] media: go7007: fix a miss of snd_card_free
To:     Markus Elfring <Markus.Elfring@web.de>
Cc:     linux-media@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Dan Carpenter <dan.carpenter@oracle.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Dec 6, 2019 at 10:11 PM Markus Elfring <Markus.Elfring@web.de> wrot=
e:
>
> > go7007_snd_init() misses a snd_card_free() in an error path.
> > Add the missed call to fix it.
>
> How do you think about to take another look also at the previous update s=
uggestion
> =E2=80=9C[PATCH 5/6] [media] go7007: Use common error handling code in go=
7007_snd_init()=E2=80=9D?
> https://lore.kernel.org/linux-media/05efac78-3a14-803c-5b4a-68670728628b@=
users.sourceforge.net/
> https://lore.kernel.org/patchwork/patch/831887/
> https://lkml.org/lkml/2017/9/19/115
>

I think using goto is really much better than freeing after every error.
I will send a new version if others also agree with this pattern.

Regards,
Chuhong

> Regards,
> Markus