Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp840380ybl; Fri, 6 Dec 2019 07:06:40 -0800 (PST) X-Google-Smtp-Source: APXvYqz2U/ZSg61She2NEEI/JQuvRCMw8yvY9W3DzL3wpmB4Q8biVJrVKahAZiVLNYOxxpkKQ+mV X-Received: by 2002:a05:6808:8ed:: with SMTP id d13mr11906369oic.93.1575644799983; Fri, 06 Dec 2019 07:06:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575644799; cv=none; d=google.com; s=arc-20160816; b=tSSn3s4AsYpvTtmPaSw9sGsJePemzLiCmR37Gha0dzjrIjoWjJZC5789zI8wqANF4e 47TLiio7tJ9yZ8zrKEHt5gIUuH7e0TWlYhjzqCXQeMWa4T2Ap5Q2+q2TYeARCei+zI0E 8KYDywyRllyZM34hOZVgLWHXWCNoDNOyoNaAg59KmXHh037u5HfxiZxZbjdux37y4EQm 3pOtfUkXub8lAZcWMWQRgfpgTgoEYipRibaB/cEtLEWv3aLfBYHtzRs/lx6PdQrHNKJp +bDo43QE7EbvFe20u6D9l+pqYfe/NYETgSp8t+JT65PtwSE+Kw7oJ1PNilwtEihvsJ4H fckg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=A4Lqa13OhNDsUds31glPAwBQMYULF2FSuTWIEeQqQxM=; b=ka2rWGssM6H199pvVxL13Mgykr4TSr6+5/VPbVW/XRJWOWuu50VRiKjQA18uwtJs4o J8GhFy8czb0MMwHXiZ6TwVc7n711RRWn9Diu6363hEo9Fl7br1OUn82MWaLlTySCrQD3 TjTuSN4J52e/iAlZOgfTvR1r2xnk0wF98hF9S6Yun6Cke24bZCNJgZ3pDUIDCYU94weB cKxwzOPYzb9DlLqsVZYzwNPGItYQzXql6wRAdEEbg9FQ8gbXGAonKf/gXSIk2hedhPJ5 ZP8gA1I7pEROCCUUzzR/S1bzmOE3wDpeUv9lxvGxQCN2jGo84JTTqj3Hpvlt2ckmZGre cemg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=FWzt3o8r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8si7026200oih.141.2019.12.06.07.06.24; Fri, 06 Dec 2019 07:06:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=FWzt3o8r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726374AbfLFPEJ (ORCPT + 99 others); Fri, 6 Dec 2019 10:04:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:59768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbfLFPEI (ORCPT ); Fri, 6 Dec 2019 10:04:08 -0500 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D76024670; Fri, 6 Dec 2019 15:04:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575644646; bh=jPJwScBR/kR2jMlDE4CcAeUQqWtkoB9V5dhy5jvHoYI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FWzt3o8rVfNQENYFugbI5qMw8n7DZBJzZazHuODQ6HTwMEtPCsUBAa4PTFRUhD7h1 E0EMt8GjGDy6t38/ZmSmhSieq3PSRVr2KbV3E/nsObtyNU6MlpwNuYFEjcCwG6tneQ 0tEBEkyyvinR7/GTUMgWW5HE3+pQ0VJ7Qad7uMek= Received: by mail-qk1-f180.google.com with SMTP id k6so6731512qki.5; Fri, 06 Dec 2019 07:04:06 -0800 (PST) X-Gm-Message-State: APjAAAVNlXmfaacdzrXe4aSxKflU8Ye43TWpv9LHk6oi9afRgT0J65HS zQhDtlOEpvHgY59n/9/3W+THrkoCfWndIq4Zxw== X-Received: by 2002:ae9:f205:: with SMTP id m5mr14467285qkg.152.1575644645684; Fri, 06 Dec 2019 07:04:05 -0800 (PST) MIME-Version: 1.0 References: <20191127084253.16356-1-geert+renesas@glider.be> <20191127084253.16356-5-geert+renesas@glider.be> <20191205210653.GA29969@bogus> In-Reply-To: From: Rob Herring Date: Fri, 6 Dec 2019 09:03:53 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 4/7] dt-bindings: gpio: Add gpio-repeater bindings To: Geert Uytterhoeven Cc: Geert Uytterhoeven , Linus Walleij , Bartosz Golaszewski , Jonathan Corbet , Mark Rutland , Harish Jenny K N , Eugeniu Rosca , Alexander Graf , Peter Maydell , Paolo Bonzini , Phil Reid , Marc Zyngier , Christoffer Dall , Magnus Damm , "open list:GPIO SUBSYSTEM" , "open list:DOCUMENTATION" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas , Linux Kernel Mailing List , QEMU Developers Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 6, 2019 at 3:17 AM Geert Uytterhoeven wrote: > > Hi Rob, > > On Thu, Dec 5, 2019 at 10:06 PM Rob Herring wrote: > > On Wed, Nov 27, 2019 at 09:42:50AM +0100, Geert Uytterhoeven wrote: > > > Add Device Tree bindings for a GPIO repeater, with optional translation > > > of physical signal properties. This is useful for describing explicitly > > > the presence of e.g. an inverter on a GPIO line, and was inspired by the > > > non-YAML gpio-inverter bindings by Harish Jenny K N > > > [1]. > > > > > > Note that this is different from a GPIO Nexus Node[2], which cannot do > > > physical signal property translation. > > > > It can't? Why not? The point of the passthru mask is to not do > > translation of flags, but without it you are always doing translation of > > cells. > > Thanks for pushing me deeper into nexuses! > You're right, you can map from one type to another. > However, you cannot handle the "double inversion" of an ACTIVE_LOW > signal with a physical inverter added: > > nexus: led-nexus { > #gpio-cells = <2>; > gpio-map = <0 0 &gpio2 19 GPIO_ACTIVE_LOW>, // inverted > <1 0 &gpio2 20 GPIO_ACTIVE_HIGH>, // noninverted > <2 0 &gpio2 21 GPIO_ACTIVE_LOW>; // inverted > gpio-map-mask = <3 0>; > // default gpio-map-pass-thru = <0 0>; > }; > > leds { > compatible = "gpio-leds"; > led6-inverted { > gpios = <&nexus 0 GPIO_ACTIVE_HIGH>; > }; > led7-noninverted { > gpios = <&nexus 1 GPIO_ACTIVE_HIGH>; > }; > led8-double-inverted { // FAILS: still inverted > gpios = <&nexus 2 GPIO_ACTIVE_LOW>; > }; > }; > > It "works" if the last entry in gpio-map is changed to GPIO_ACTIVE_HIGH. > Still, the consumer would see the final translated polarity, and not the > actual one it needs to program the consumer for. I'm not really following. Why isn't a double inversion just the same as no inversion? > > > While an inverter can be described implicitly by exchanging the > > > GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW flags, this has its limitations. > > > Each GPIO line has only a single GPIO_ACTIVE_* flag, but applies to both > > > th provider and consumer sides: > > > 1. The GPIO provider (controller) looks at the flags to know the > > > polarity, so it can translate between logical (active/not active) > > > and physical (high/low) signal levels. > > > 2. While the signal polarity is usually fixed on the GPIO consumer > > > side (e.g. an LED is tied to either the supply voltage or GND), > > > it may be configurable on some devices, and both sides need to > > > agree. Hence the GPIO_ACTIVE_* flag as seen by the consumer must > > > match the actual polarity. > > > There exists a similar issue with interrupt flags, where both the > > > interrupt controller and the device generating the interrupt need > > > to agree, which breaks in the presence of a physical inverter not > > > described in DT (see e.g. [3]). > > > > Adding an inverted flag as I've suggested would also solve this issue. > > As per your suggestion in "Re: [PATCH V4 2/2] gpio: inverter: document > the inverter bindings"? > https://lore.kernel.org/linux-devicetree/CAL_JsqLp___2O-naU+2PPQy0QmJX6+aN3hByz-OB9+qFvWgN9Q@mail.gmail.com/ > > Oh, now I understand. I was misguided by Harish' interpretation > https://lore.kernel.org/linux-devicetree/dde73334-a26d-b53f-6b97-4101c1cdc185@mentor.com/ > which assumed an "inverted" property, e.g. > > inverted = /bits/ 8 <0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0>; > > But you actually meant a new GPIO_INVERTED flag, to be ORed into the 2nd > cell of a GPIO specifier? I.e. add to include/dt-bindings/gpio/gpio.h" > > /* Bit 6 expresses the presence of a physical inverter */ > #define GPIO_INVERTED 64 Exactly. > We need to be very careful in defining to which side the GPIO_ACTIVE_* > applies to (consumer?), and which side the GPIO_INVERTED flag (provider?). > Still, this doesn't help if e.g. a FET is used instead of a push-pull > inverter, as the former needs translation of other flags (which the > nexus can do, the caveats above still applies, though). Yes. Historically the cells values are meaningful to the provider and opaque to the consumer. Standardized cell values changes that somewhat. I think we want the active flag to be from the provider's prospective because the provider always needs to know. The consumer often doesn't need to know. That also means things work without the GPIO_INVERTED flag if the consumer doesn't care which is what we have today already and we can't go back in time. > Same for adding IRQ_TYPE_INVERTED. I suppose so, yes. > Related issue: how to handle physical inverters on SPI chip select lines, > if the SPI slave can be configured for both polarities? Good question. Perhaps in a different way because we have to handle both h/w controlled and gpio chip selects. However, how would one configure the polarity in the device in the first place? You have to assert the CS first to give a command to reprogram it. Rob