Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191118173002.32015-1-steven.price@arm.com>
In-Reply-To: <20191118173002.32015-1-steven.price@arm.com>
From:   Rob Herring <robh@kernel.org>
Date:   Fri, 6 Dec 2019 11:16:48 -0600
Message-ID: <CAL_JsqL2-3+rBHJzfsQfz=hKt3kt+wh5tmXd0Wa-1QFLo3=57w@mail.gmail.com>
Subject: Re: [PATCH] drm/panfrost: devfreq: Round frequencies to OPPs
To:     Steven Price <steven.price@arm.com>
Cc:     Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 18, 2019 at 11:30 AM Steven Price <steven.price@arm.com> wrote:
>
> Currently when setting a frequency in panfrost_devfreq_target the
> returned frequency is the actual frequency that the clock driver reports
> (the return of clk_get_rate()). However, where the provided OPPs don't
> precisely match the frequencies that the clock actually achieves devfreq
> will then complain (repeatedly):
>
>   devfreq devfreq0: Couldn't update frequency transition information.
>
> To avoid this change panfrost_devfreq_target() to fetch the opp using
> devfreq_recommened_opp() and not actually query the clock for the
> frequency.
>
> A similar problem exists with panfrost_devfreq_get_cur_freq(), but in
> this case because the function is optional we can just remove it and
> devfreq will fall back to using the previously set frequency.
>
> Fixes: 221bc77914cb ("drm/panfrost: Use generic code for devfreq")
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
>  drivers/gpu/drm/panfrost/panfrost_devfreq.c | 19 ++++++-------------
>  1 file changed, 6 insertions(+), 13 deletions(-)

Applied.

Rob