Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 6 Dec 2019 10:53:01 -0800
From:   Oliver Upton <oupton@google.com>
To:     Krish Sadhukhan <krish.sadhukhan@oracle.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: nVMX: expose "load IA32_PERF_GLOBAL_CTRL" controls
Message-ID: <20191206185301.GA93531@google.com>
References: <1574346557-18344-1-git-send-email-pbonzini@redhat.com>
 <7fea1f06-9abb-cdd1-9cb9-8655fe207e96@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7fea1f06-9abb-cdd1-9cb9-8655fe207e96@oracle.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Paolo,

Sorry I didn't see this earlier. Thank you for addressing this!

On Thu, Nov 21, 2019 at 10:42:18AM -0800, Krish Sadhukhan wrote:
> 
> On 11/21/19 6:29 AM, Paolo Bonzini wrote:
> > These controls were added by the recent commit 03a8871add95 ("KVM:
> > nVMX: Expose load IA32_PERF_GLOBAL_CTRL VM-{Entry,Exit} control",
> > 2019-11-13), so we should advertise them to userspace from
> > KVM_GET_MSR_FEATURE_INDEX_LIST, as well.
> > 
> > Cc: Oliver Upton <oupton@google.com>
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> >   arch/x86/kvm/vmx/nested.c | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> > index 4aea7d304beb..4b4ce6a804ff 100644
> > --- a/arch/x86/kvm/vmx/nested.c
> > +++ b/arch/x86/kvm/vmx/nested.c
> > @@ -5982,6 +5982,7 @@ void nested_vmx_setup_ctls_msrs(struct nested_vmx_msrs *msrs, u32 ept_caps,
> >   #ifdef CONFIG_X86_64
> >   		VM_EXIT_HOST_ADDR_SPACE_SIZE |
> >   #endif
> > +		VM_EXIT_LOAD_IA32_PERF_GLOBAL_CTRL |
> >   		VM_EXIT_LOAD_IA32_PAT | VM_EXIT_SAVE_IA32_PAT;
> >   	msrs->exit_ctls_high |=
> >   		VM_EXIT_ALWAYSON_WITHOUT_TRUE_MSR |
> > @@ -6001,6 +6002,7 @@ void nested_vmx_setup_ctls_msrs(struct nested_vmx_msrs *msrs, u32 ept_caps,
> >   #ifdef CONFIG_X86_64
> >   		VM_ENTRY_IA32E_MODE |
> >   #endif
> > +		VM_ENTRY_LOAD_IA32_PERF_GLOBAL_CTRL |
> >   		VM_ENTRY_LOAD_IA32_PAT;
> >   	msrs->entry_ctls_high |=
> >   		(VM_ENTRY_ALWAYSON_WITHOUT_TRUE_MSR | VM_ENTRY_LOAD_IA32_EFER);
> Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
Reviewed-by: Oliver Upton <oupton@google.com>