Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191202114221.827-1-sjpark@amazon.com>
In-Reply-To: <20191202114221.827-1-sjpark@amazon.com>
From:   SeongJae Park <sj38.park@gmail.com>
Date:   Fri, 6 Dec 2019 20:31:21 +0100
Message-ID: <CAEjAshq_nfY2MRuXwvN7hoX9jOxkO1C+g5AH1KJbDS=wxVSC5Q@mail.gmail.com>
Subject: Re: [PATCH 1/2] kselftest/runner: Print new line in print of timeout log
To:     SeongJae Park <sjpark@amazon.com>
Cc:     Shuah Khan <shuah@kernel.org>, Kees Cook <keescook@chromium.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        SeongJae Park <sjpark@amazon.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Shuah,


May I ask your comments?


Thanks,
SeongJae Park

On Mon, Dec 2, 2019 at 12:42 PM SeongJae Park <sjpark@amazon.com> wrote:
>
> From: SeongJae Park <sjpark@amazon.de>
>
> If a timeout failure occurs, kselftest kills the test process and prints
> the timeout log.  If the test process has killed while printing a log
> that ends with new line, the timeout log can be printed in middle of the
> test process output so that it can be seems like a comment, as below:
>
>     # test_process_log  not ok 3 selftests: timers: nsleep-lat # TIMEOUT
>
> This commit avoids such problem by printing one more line before the
> TIMEOUT failure log.
>
> Signed-off-by: SeongJae Park <sjpark@amazon.de>
> ---
>  tools/testing/selftests/kselftest/runner.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh
> index 84de7bc74f2c..a8d20cbb711c 100644
> --- a/tools/testing/selftests/kselftest/runner.sh
> +++ b/tools/testing/selftests/kselftest/runner.sh
> @@ -79,6 +79,7 @@ run_one()
>                 if [ $rc -eq $skip_rc ]; then   \
>                         echo "not ok $test_num $TEST_HDR_MSG # SKIP"
>                 elif [ $rc -eq $timeout_rc ]; then \
> +                       echo "#"
>                         echo "not ok $test_num $TEST_HDR_MSG # TIMEOUT"
>                 else
>                         echo "not ok $test_num $TEST_HDR_MSG # exit=$rc"
> --
> 2.17.1
>