Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <81423.1575627938@turing-police>
References: <20191125000326.24561-1-namjae.jeon@samsung.com>
 <CGME20191125000628epcas1p28c532d9b7f184945c40e019ce9ef0dd0@epcas1p2.samsung.com>
 <20191125000326.24561-3-namjae.jeon@samsung.com> <81423.1575627938@turing-police>
From:   Namjae Jeon <linkinjeon@gmail.com>
Date:   Sat, 7 Dec 2019 06:55:25 +0900
Message-ID: <CAKYAXd9yW2j+MqExyxJmN2-bTKMarwebrBKefBZgfj+HF+bpbg@mail.gmail.com>
Subject: Re: [PATCH v5 02/13] exfat: add super block operations
To:     =?UTF-8?Q?Valdis_Kl=C4=93tnieks?= <valdis.kletnieks@vt.edu>
Cc:     Namjae Jeon <namjae.jeon@samsung.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        gregkh@linuxfoundation.org, hch@lst.de, Markus.Elfring@web.de,
        sj1557.seo@samsung.com, dwagner@suse.de, nborisov@suse.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

>> +{
>> +	struct exfat_sb_info *sbi = sb->s_fs_info;
>> +	struct exfat_mount_options *opts = &sbi->options;
>> +	struct inode *root_inode;
>> +	int err;
>> +
>> +	if (opts->allow_utime == -1)
>> +		opts->allow_utime = ~opts->fs_dmask & 0022;
>
> This throws a warning when building with W=1:
>
>   CC [M]  fs/exfat/super.o
> fs/exfat/super.c: In function 'exfat_fill_super':
> fs/exfat/super.c:552:24: warning: comparison is always false due to limited
> range of data type [-Wtype-limits]
>   552 |  if (opts->allow_utime == -1)
>       |                        ^~
Okay, I will fix it on next version.
Thanks for review!