Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 7 Dec 2019 10:33:48 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Wolfram Sang <wsa@the-dreams.de>
Cc:     Geert Uytterhoeven <geert+renesas@glider.be>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Jacopo Mondi <jacopo+renesas@jmondi.org>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        linux-iio@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: max9611: Fix too short conversion time
 delay
Message-ID: <20191207103348.58df9cd5@archlinux>
In-Reply-To: <20191202092328.GE1266@kunai>
References: <20191202085546.21655-1-geert+renesas@glider.be>
        <20191202092328.GE1266@kunai>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2 Dec 2019 10:23:29 +0100
Wolfram Sang <wsa@the-dreams.de> wrote:

> On Mon, Dec 02, 2019 at 09:55:46AM +0100, Geert Uytterhoeven wrote:
> > As of commit b9ddd5091160793e ("iio: adc: max9611: Fix temperature
> > reading in probe"), max9611 initialization sometimes fails on the
> > Salvator-X(S) development board with:
> >=20
> >     max9611 4-007f: Invalid value received from ADC 0x8000: aborting
> >     max9611: probe of 4-007f failed with error -5
> >=20
> > The max9611 driver tests communications with the chip by reading the die
> > temperature during the probe function, which returns an invalid value.
> >=20
> > According to the datasheet, the typical ADC conversion time is 2 ms, but
> > no minimum or maximum values are provided.  Maxim Technical Support
> > confirmed this was tested with temperature Ta=3D25 degreeC, and promised
> > to inform me if a maximum/minimum value is available (they didn't get
> > back to me, so I assume it is not).
> >=20
> > However, the driver assumes a 1 ms conversion time.  Usually the
> > usleep_range() call returns after more than 1.8 ms, hence it succeeds.
> > When it returns earlier, the data register may be read too early, and
> > the previous measurement value will be returned.  After boot, this is
> > the temperature POR (power-on reset) value, causing the failure above.
> >=20
> > Fix this by increasing the delay from 1000-2000 =C2=B5s to 3000-3300 =
=C2=B5s.
> >=20
> > Note that this issue has always been present, but it was exposed by the
> > aformentioned commit.
> >=20
> > Fixes: 69780a3bbc0b1e7e ("iio: adc: Add Maxim max9611 ADC driver")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org> =20
>=20
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>=20
> One minor nit, though:
>=20
> >  	/*
> >  	 * need a delay here to make register configuration
> > -	 * stabilize. 1 msec at least, from empirical testing.
> > +	 * stabilize. =20
>=20
> This could be a one line comment now?
>=20

Applied to the fixes-togreg branch of iio.git and tidied up.

Thanks,

Jonathan