Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2014767ybl; Sat, 7 Dec 2019 06:41:25 -0800 (PST) X-Google-Smtp-Source: APXvYqwkTmaM+Q6Nw+91dP3pt8OcV3huULFyOYMI7uvp+Qq2C85cO/SPkNIt6OQKNXU9KFhSAQgV X-Received: by 2002:a05:6830:2110:: with SMTP id i16mr14973284otc.337.1575729685851; Sat, 07 Dec 2019 06:41:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575729685; cv=none; d=google.com; s=arc-20160816; b=yaFsYQS5erchpFhMrYwzNiY1D6ID1+rpMYT++ujx2cIH68kXruE3aILx2TAYfwEzER BSAevt5ESE8UzW9YMpE7w0GJSNbcpQ6oxmzRHjXeMWELGrlbNRDgx6jVNy54Xbfz8cqj 00yqqiEz6CiZzGLd+cug5fMS5Ck2efIXOb4BRu+aLg86KiAzj5ilD6v4d9P661ZU5Uie 8mnUUSlRmp/F/diFETDz+rUeHJKAG7iIVPOTR1T3ZraX0lmOiOy7T/ojthlP0LoIKjms CzefzP6c1AK114lpgFKPyC5XMwHS7hHg3+wU9zSCRPSZl5HvcYiUMghdmU6LhrV0ybaO +Jfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=dJSkc7mHy0Apqqs0LOjlNBmO4HliOsLD/T1QQYCdge0=; b=0YsSs7MazxRQ0Ah4FbTwegWFm/KPsO/JZy+As3S5wg/uZnHvWiDg2vBv6JKNU3Jcv1 /bayFiTzp8s/wVGtNClOLDomfZCXov6ymjCVlkt9CYPFQzVJgatdhLZaZxr1HvrHBP4r JK2vm/1UG3NuHXXyPCXZUydCPmRm5G4ah6njlyUYOSMHJKFJ2tTRvXnPhLGQ2gFTIKkg 1M7/Eq6oqtcd7KBkmJwnIPyUaDWT3vJvz+0VG7MZB2ns9ucWcmrojVbAoyyFSJL8Z/U5 ssf1/SvcaO7PECtaVJmmSzDqqfxKvbyebsG/RVONFyY76DYtL6Pqz5LSgiSspAVraMro gLpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JyikBE6L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v202si7658716oie.79.2019.12.07.06.41.11; Sat, 07 Dec 2019 06:41:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JyikBE6L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726461AbfLGOkk (ORCPT + 99 others); Sat, 7 Dec 2019 09:40:40 -0500 Received: from mail-pj1-f68.google.com ([209.85.216.68]:41333 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726399AbfLGOkj (ORCPT ); Sat, 7 Dec 2019 09:40:39 -0500 Received: by mail-pj1-f68.google.com with SMTP id ca19so3969432pjb.8; Sat, 07 Dec 2019 06:40:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=dJSkc7mHy0Apqqs0LOjlNBmO4HliOsLD/T1QQYCdge0=; b=JyikBE6LfTErMnXoY2J7brZ22XidEnntk3Ppx7Q0+EPwbg43lZiK2Yka3L/J6PxB0S 1ucxh4+rFD5eFPnKDL9xE7n4Bwv6cKcJgeXw8eMxNrAv8hejyMlVbjFyeJAeaTJUXsS0 COWPlU8WEs5vKtLDQyddg7xDBDvtRMVuQPOyVMU7i8NS2++KR9awdNic92RJZlbu0ByH t+JAlXn2HodC3SBMHdytNVqRih6zILWWstixUp7OLU3nzQCIyqKL3GfFOnkJjqtg60Kf O82ySCpooMwCCB7WMUimPNT4Q2wjShP/mct4fqAFVrTii+uP5uphFKp7CLcJ0L5j2tV2 gIhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dJSkc7mHy0Apqqs0LOjlNBmO4HliOsLD/T1QQYCdge0=; b=FtaqwWTEuDDWHZQO7jUHJ5O4e1oNxkozL/6gXq4uQZR7l0JrpBqKpbpPWi41f3P6+S GRmXhTp1dJYR+pnHI8OSmoW7FvDSTCj/gMH+TlqP+PGPvLpIK+R38ljAvsClRkpbwdLK Qhg6t1WzlLvCS5nBH7bkXkgzGVMTtOhmU2v5YcwevBzFaE0JpgLzK0TxWLf4ShGgopkR kxBFXgLStwVzljapu3bByqFBKUwAPXCfx/bngMfQNo78kjPPb+0hDH9npIAIexEoUFj5 uynR1g1FeLKlIA4o24GLEQMQNg1cvsoH+VpaPQnSjkLtiqwz4QGgg5gLub5OZG+vGx4N z4oA== X-Gm-Message-State: APjAAAXCG9fKMA/IKwBTSSavzVmjgaoYUYlX/HYemX9THpN0SbpyBOOJ x8ksR2MCN4hKIQ5JSFETpio= X-Received: by 2002:a17:90a:9f04:: with SMTP id n4mr21892610pjp.76.1575729639021; Sat, 07 Dec 2019 06:40:39 -0800 (PST) Received: from localhost.localdomain ([222.209.84.125]) by smtp.gmail.com with ESMTPSA id 23sm6925126pjx.29.2019.12.07.06.40.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 07 Dec 2019 06:40:38 -0800 (PST) From: Xiaolong Huang To: wg@grandegger.com, mkl@pengutronix.de Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Xiaolong Huang Subject: [PATCH] can: kvaser_usb: kvaser_usb_leaf: Fix some info-leaks to USB devices Date: Sat, 7 Dec 2019 22:40:24 +0800 Message-Id: <1575729624-5917-1-git-send-email-butterflyhuangxx@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Uninitialized Kernel memory can leak to USB devices. Using kzalloc() instead of kmalloc() Signed-off-by: Xiaolong Huang --- drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c b/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c index 07d2f3a..ae4c37e 100644 --- a/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c +++ b/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c @@ -608,7 +608,7 @@ static int kvaser_usb_leaf_simple_cmd_async(struct kvaser_usb_net_priv *priv, struct kvaser_cmd *cmd; int err; - cmd = kmalloc(sizeof(*cmd), GFP_ATOMIC); + cmd = kzalloc(sizeof(*cmd), GFP_ATOMIC); if (!cmd) return -ENOMEM; @@ -1140,7 +1140,7 @@ static int kvaser_usb_leaf_set_opt_mode(const struct kvaser_usb_net_priv *priv) struct kvaser_cmd *cmd; int rc; - cmd = kmalloc(sizeof(*cmd), GFP_KERNEL); + cmd = kzalloc(sizeof(*cmd), GFP_KERNEL); if (!cmd) return -ENOMEM; @@ -1206,7 +1206,7 @@ static int kvaser_usb_leaf_flush_queue(struct kvaser_usb_net_priv *priv) struct kvaser_cmd *cmd; int rc; - cmd = kmalloc(sizeof(*cmd), GFP_KERNEL); + cmd = kzalloc(sizeof(*cmd), GFP_KERNEL); if (!cmd) return -ENOMEM; -- 2.7.4