Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2017299ybl; Sat, 7 Dec 2019 06:44:34 -0800 (PST) X-Google-Smtp-Source: APXvYqyi6PzjbBUP4jt/J/uij3X0hYmbDn5VtHx0cixVok9m9iHhy2xxDohlc01w+3Nf49l092bL X-Received: by 2002:a9d:61c4:: with SMTP id h4mr15888783otk.310.1575729874023; Sat, 07 Dec 2019 06:44:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575729874; cv=none; d=google.com; s=arc-20160816; b=oe1c8Ot4Io1DjRLooVM7xT7HuntNMWFr8G6TlZO5dVGWLvZEJQHnUKqFG1jePxgNsh W0zDMUv98/yeif9ittKbf2jbxNLNn4x2xRdlFr3y3HSZdjsAbBnaCv+7mOo/DVLTvl9a IOWYyypnvzJPU3Ybcp4ojFX0FZ/atAEfxMLKJ0D2DW0eUrQGEHd97IRPP+PGtp5PWPXm EsZ8KPhtettlc06Lxb1ljdY1gx6Klm7JxaBiQAFXpSdAj1FBf/I5514vb44oDdnY7s2a LCwo6/ErL78brVeu47EMVABuBwA4+CjWeOgfh2SFk8H7ZKmUeWPnTmwlZh4iY1Pzh4h6 V4TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:dkim-signature; bh=M4178m5wqKcjur6WZ9VbgwAy1j68KdshPPjyIN/6tPs=; b=xHH9SxBIUu12MAAsAjzb3gphaJ8yLiacC3SjMvejxTlWVK3Hu1lfYqBEghmufJpyR3 Q99xEYPbWoAfBYWphn71+IcPqfDXqn0KxkQ1A/q+Ay0oTNJ6+eEvXKNsy7kAgl6UdjWC 4MwgHCiDkAOGeGnpVuxF1wIH9dRIKEjXVcjHa1reP/Pp0JmVvZUmrBU3q82N7Fe42bAf bIwWO7vczvMDESI5zgr60sxtcAMFphrP1jm+dnnNqSCwSzx2UKLr5Dc9/doAPKFmiU+H 5Az/FvxfnBRVxmGBi/RKTNm/ITtcVLO9w1SZWPc5Gg0UaaM5tTCw81CeJn2NB7kFRGGH eQ8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JEXsRsUj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t7si7875386otl.133.2019.12.07.06.44.22; Sat, 07 Dec 2019 06:44:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JEXsRsUj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726465AbfLGOnx (ORCPT + 99 others); Sat, 7 Dec 2019 09:43:53 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:42052 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726400AbfLGOnx (ORCPT ); Sat, 7 Dec 2019 09:43:53 -0500 Received: by mail-lj1-f194.google.com with SMTP id e28so10743452ljo.9; Sat, 07 Dec 2019 06:43:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=M4178m5wqKcjur6WZ9VbgwAy1j68KdshPPjyIN/6tPs=; b=JEXsRsUjV2g10sr0Ks0k3FUw9U5Tv97+5vrfYHJZOIcNSgd6M+N5vTtgaCHX3c8/8a +oNhdRKUkWMzF/WSTpiuN4ecPb7ElQcmbs2mNsXjcnxARF1D/yvdqxmsTYRUbn6iq9EX QWPn4LtwsAJt2utSabQVTf8KbxeHmW61Q93SPmk9gzIFH8IyCqeH3royTvXmlDHUqMiX JXzhDznChEN8g9jgpuJyTjWuW3g57aSUeC/E3MrGn7Z+ZoDte3AzDVtEH8M0HlO9Mp4i AtmyKD5OcVxL7iXM/75BCdU8CI9/SZEArBOGMMhwzOagt8LV3x/rei58gUrWU05odAD8 y0/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=M4178m5wqKcjur6WZ9VbgwAy1j68KdshPPjyIN/6tPs=; b=hcJh6kbCTLgxHjrLlas+Cl3dLyXDEbha6PDQ8KSl4Na6/sJBgHqNz9PnJEN/vOqEL3 E5lYVf/RJl8ILwv1c8q4IrsCaeQWQ5idE31TikA+S+XZjjGU58yt5ylxEkW/7M8mONUt OGVvOurwB4bhlyD+2qXlVCZDkgCFUoe5CdpqeLfKU6ws7IyqWLpCAtQl+SzLRcJsP6/Y Ia7d+ZtBn+fAjJnjc270P7DFcssSNmm5GQgi8aTY5C8E7YLDM//ydsH00xcQ58mYJQo4 0Z1MCNzG8+ehKcTrEJknVF9A0YX2Ed0Kg2d/j+RSzYKuhTKp0W5WiXi85MNXOkelFSDd NRhA== X-Gm-Message-State: APjAAAWdKv9Wk6U0h2yxF/dyeALCB7+TJHqBNRzsSMwoMKrmVfyVXTb4 flej5HQo5r6e46N88buQGW4= X-Received: by 2002:a2e:8e72:: with SMTP id t18mr2688107ljk.132.1575729830747; Sat, 07 Dec 2019 06:43:50 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id w2sm8155909ljo.61.2019.12.07.06.43.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Dec 2019 06:43:50 -0800 (PST) Subject: Re: [PATCH v3 06/15] clk: tegra: Remove tegra_pmc_clk_init along with clk ids From: Dmitry Osipenko To: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, mperttunen@nvidia.com, gregkh@linuxfoundation.org, sboyd@kernel.org, tglx@linutronix.de, robh+dt@kernel.org, mark.rutland@arm.com Cc: allison@lohutok.net, pdeschrijver@nvidia.com, pgaikwad@nvidia.com, mturquette@baylibre.com, horms+renesas@verge.net.au, Jisheng.Zhang@synaptics.com, krzk@kernel.org, arnd@arndb.de, spujar@nvidia.com, josephl@nvidia.com, vidyas@nvidia.com, daniel.lezcano@linaro.org, mmaddireddy@nvidia.com, markz@nvidia.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alexios.zavras@intel.com, alsa-devel@alsa-project.org References: <1575600535-26877-1-git-send-email-skomatineni@nvidia.com> <1575600535-26877-7-git-send-email-skomatineni@nvidia.com> <3880aa15-c47a-5ab2-dd39-e8a47f6a3d6a@gmail.com> Message-ID: Date: Sat, 7 Dec 2019 17:43:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <3880aa15-c47a-5ab2-dd39-e8a47f6a3d6a@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 07.12.2019 17:33, Dmitry Osipenko пишет: > 06.12.2019 05:48, Sowjanya Komatineni пишет: >> Current Tegra clock driver registers PMC clocks clk_out_1, clk_out_2, >> clk_out_3 and blink output in tegra_pmc_init() which does direct Tegra >> PMC access during clk_ops and these PMC register read and write access >> will not happen when PMC is in secure mode. >> >> Any direct PMC register access from non-secure world will not go >> through and all the PMC clocks and blink control are done in Tegra PMC >> driver with PMC as clock provider. >> >> This patch removes tegra_pmc_clk_init along with corresponding clk ids >> from Tegra clock driver. >> >> Signed-off-by: Sowjanya Komatineni >> --- > > [snip] > >> @@ -1230,9 +1222,6 @@ static struct tegra_clk_init_table init_table[] __initdata = { > >> { TEGRA30_CLK_PLL_A, TEGRA30_CLK_CLK_MAX, 564480000, 1 }, >> { TEGRA30_CLK_PLL_A_OUT0, TEGRA30_CLK_CLK_MAX, 11289600, 1 }, >> { TEGRA30_CLK_EXTERN1, TEGRA30_CLK_PLL_A_OUT0, 0, 1 }, > > Perhaps these clocks do not need to be always-enabled? > > [snip] > Also, EXTERN1 parent configuration should be moved to the audio driver/device-tree as well. Maybe it even makes sense to move the whole configuration, including PLLA. I don't see why clk driver need to do something for the audio driver.