Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191207144126.14320-1-dinghao.liu@zju.edu.cn>
In-Reply-To: <20191207144126.14320-1-dinghao.liu@zju.edu.cn>
Reply-To: fdmanana@gmail.com
From:   Filipe Manana <fdmanana@gmail.com>
Date:   Sat, 7 Dec 2019 17:16:10 +0000
Message-ID: <CAL3q7H48ObWGwY=C=L45CKkC4D1nLUr0s3_YUwHPSCmirKmidA@mail.gmail.com>
Subject: Re: [PATCH] fs: Fix a missing check bug
To:     Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc:     kjlu@umn.edu, pakki001@umn.edu, Chris Mason <clm@fb.com>,
        Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>,
        linux-btrfs <linux-btrfs@vger.kernel.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Dec 7, 2019 at 3:03 PM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
>
> The return value of link_free_space(ctl, info) is checked out-sync. Only =
one branch of an if statement checks this return value after WARN_ON(ret).
>
> Since this path pair is similar in semantic, there might be a missing che=
ck bug.
>
> Fix this by simply adding a check on ret.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
>  fs/btrfs/free-space-cache.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
> index 3283da419200..acbb3a59d344 100644
> --- a/fs/btrfs/free-space-cache.c
> +++ b/fs/btrfs/free-space-cache.c
> @@ -2437,6 +2437,8 @@ int btrfs_remove_free_space(struct btrfs_block_grou=
p *block_group,
>                         if (info->bytes) {
>                                 ret =3D link_free_space(ctl, info);
>                                 WARN_ON(ret);
> +                               if (ret)

I think the WARN_ON() can go away as well.
The only possible error is -EEXIST, coming from tree_insert_offset().
When that happens tree_insert_offset() already emits a warning.

Also, the free space entry needs to be freed, otherwise we leak
memory. So it should be something like this:

if (ret) {
    kmem_cache_free(btrfs_free_space_cachep, info);
    goto out_unlock;
}

Further the subject should be prefixed with "btrfs: " and not "fs: ",
since this is a btrfs specific patch.
Something like the following for example:

"btrfs: add missing error handling when removing free space"

Thanks.

> +                                       goto out_lock;
>                         } else {
>                                 kmem_cache_free(btrfs_free_space_cachep, =
info);
>                         }
> --
> 2.21.0 (Apple Git-122)
>


--=20
Filipe David Manana,

=E2=80=9CWhether you think you can, or you think you can't =E2=80=94 you're=
 right.=E2=80=9D