Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 07 Dec 2019 11:50:34 -0800 (PST)
Message-Id: <20191207.115034.1743579700466281633.davem@davemloft.net>
To:     ivan.khoronzhuk@linaro.org
Cc:     grygorii.strashko@ti.com, netdev@vger.kernel.org, nsekhar@ti.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: ethernet: ti: davinci_cpdma: fix warning
 "device driver frees DMA memory with different size"
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20191207120238.GB2798@khorivan>
References: <0c6b88b2-31b1-11f0-7baa-1ecd5f4b6644@ti.com>
        <20191207114419.GA2798@khorivan>
        <20191207120238.GB2798@khorivan>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Date: Sat, 7 Dec 2019 14:02:39 +0200

> @@ -1046,7 +1045,6 @@ static int cpdma_chan_submit_si(struct
> submit_info *si)
>        if (si->data_dma) {
>                buffer = si->data_dma;
>                dma_sync_single_for_device(ctlr->dev, buffer, len, chan->dir);
> -               swlen |= CPDMA_DMA_EXT_MAP;
>        } else {
>                buffer = dma_map_single(ctlr->dev, si->data_virt, len, chan->dir);
>                ret = dma_mapping_error(ctlr->dev, buffer);
> @@ -1065,7 +1063,7 @@ static int cpdma_chan_submit_si(struct
> submit_info *si)
>        writel_relaxed(mode | len, &desc->hw_mode);
>        writel_relaxed((uintptr_t)si->token, &desc->sw_token);
>        writel_relaxed(buffer, &desc->sw_buffer);
> -       writel_relaxed(swlen, &desc->sw_len);
> + writel_relaxed(si->data_dma ? len | CPDMA_DMA_EXT_MAP : len,
> &desc->sw_len);
>        desc_read(desc, sw_len);
> 
>        __cpdma_chan_submit(chan, desc);
> 
> But it's branched twice then.

It's a conditional move rather than a branch....