Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2279576ybl; Sat, 7 Dec 2019 11:53:20 -0800 (PST) X-Google-Smtp-Source: APXvYqzGUpKkxR/p1cGoVc24VxMXRWDA0ynsA+WTxNq9Qi7u/cudqJcQ/8Fm1hg9qfe4abNX07uw X-Received: by 2002:a9d:5902:: with SMTP id t2mr17070022oth.151.1575748400154; Sat, 07 Dec 2019 11:53:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575748400; cv=none; d=google.com; s=arc-20160816; b=wBOknNjPQsxZhk77oyel/4XslvHnBWXXVVodNvOHsCiHn+36186IR37O1CmPsMcBxj 9JPTzDfQEbBxI5PctA7J0VqvgCdCb6B1WcUUKq92nXu21BNErMixEnVcwV1XcLMuvQZy THMGeg3Y1ScQV7cXbrKM20Rok1d9pYw9HlustOjG+Zxtapj1QMgcOmMt8q+iMvPwWbgv OC+zko+8smrwgCrAQv1nFlMpqY0HJk2rpqTwXHRtWb2xVUA0VWQGdxcnp+3dn73BS+OF 5r4QWQVZ0cIrxqntmghilAnetrN1PLfG2Z6503X0dOsbLbc3T+ts2jsqKuk70EXIByQB SRlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=HQIda3hpOaoTGb0l1/AbMkg7Y1BQ21bIBoqliOEvoiQ=; b=UDRIpXvmqBNQU58z01LFnwz0+EAHH37a/9jMrlZGMed1DrBuTvWqc4LrAD1hPmUVu9 Z9NXo0zptHc2P5Vwt5ftnHgS28w/6W5kELz3vv1b47F/bFQiXOdrgDPDEGYbGBEUu2CU js/mwgQv+iWAUjFKPsNbaHT8nHPoD85btlgoDLoiZRKzaw9+ZGnTJMYZtRUcb0CRnxoH QwWab4q139ZS+ucTrjIN7rIA5kkoliFBlJWeQFXkRXZk0r3gTwLZVmvxdZj3RscqW1Hu Rh2Px6wdZPOb6dBBX8gAR3dtaGtjnPvDKfh59nyLeD7Tb75BF0BslrS6VzsgKBQgpYOO KB1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b20si450184otl.159.2019.12.07.11.53.08; Sat, 07 Dec 2019 11:53:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726743AbfLGTwk (ORCPT + 99 others); Sat, 7 Dec 2019 14:52:40 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:42752 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726489AbfLGTwj (ORCPT ); Sat, 7 Dec 2019 14:52:39 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3F27615420D23; Sat, 7 Dec 2019 11:52:39 -0800 (PST) Date: Sat, 07 Dec 2019 11:52:38 -0800 (PST) Message-Id: <20191207.115238.784174182997766329.davem@davemloft.net> To: pakki001@umn.edu Cc: kjlu@umn.edu, mostrows@earthlink.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pppoe: remove redundant BUG_ON() check in pppoe_pernet From: David Miller In-Reply-To: <20191205230450.8614-1-pakki001@umn.edu> References: <20191205230450.8614-1-pakki001@umn.edu> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 07 Dec 2019 11:52:39 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aditya Pakki Date: Thu, 5 Dec 2019 17:04:49 -0600 > Passing NULL to pppoe_pernet causes a crash via BUG_ON. > Dereferencing net in net_generici() also has the same effect. This patch > removes the redundant BUG_ON check on the same parameter. > > Signed-off-by: Aditya Pakki Applied.