Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2377557ybl; Sat, 7 Dec 2019 14:05:04 -0800 (PST) X-Google-Smtp-Source: APXvYqxMrJ9a7tFmKuDzVbqtDR93FUcvUPVtFOSMicoQauIJ4DlCBIQV/yYxcP2rSF7t87YMjPPs X-Received: by 2002:a05:6830:1e75:: with SMTP id m21mr15884267otr.36.1575756304655; Sat, 07 Dec 2019 14:05:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575756304; cv=none; d=google.com; s=arc-20160816; b=X1MuWir5BvCn71m/HrBC0iWdpOM5T00/TrBGCzzNedVWe+5hb5q4EFm6Cow/e+E/Ji OEnLM5o7nTpOcyJH/M8/w4ZcIJ7rpZE0/o/ol5kg0BnEHlbxLekgwSF6gUu3aXeDxUgG JrCG0Ott/MD93wY6xNvjceSi6Z0Dvt1qwBgFx9oKWHTxcK1wwZGCkAgQ+7f5Ov6jG42w SSq40AV/52xWHUfKojNd6DZx2xU4C//dpHJkbYFM8hyDFPe6yPe7643H7ifEf5j5kS7s 8NwghFc3Nc2Uj+AZrCxjdGPNA2nA6IAuQ86TCyANvl1gblrZbnJvsyVA39yKw8UnjRvt MiCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5nppC0dn8qY+mD1E09P6PznSd/Bh4xxBWze2A2WO09Q=; b=CMB3Q29m1tly+oYSOj2WpatK3KhV/CgJOgY3kYCMCVOV7PsJ5vhrnrs63gSQxhLO7L 43ozFW0R3VvoJA0nQIQ7Gw8LwIvxUKkqncooB7EJ5W4Ixl3lIiSjJhcXKekFoGQoCmT3 bQvDtETOObZJ88JiYcyAimQXcO/DMp52OEN0hidZD5An1PNEwz0V5LIoIxB4DrO4edEC KpX8/7/hTW5k+8nNNPJX6pGJdFTxUiogT/TV3h3JkzrRurYjCCHb71wxn3rG6xejoMQP zXigpBddUPJWmIanQc8EVsegTc+e+mUsbGmPtRaVphAEi3GAY9qa+UP6v6qvc4RjVbL4 D9/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=IlO3aG3F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j23si9064802otr.48.2019.12.07.14.04.50; Sat, 07 Dec 2019 14:05:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=IlO3aG3F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726427AbfLGWD1 (ORCPT + 99 others); Sat, 7 Dec 2019 17:03:27 -0500 Received: from mail-il1-f194.google.com ([209.85.166.194]:41430 "EHLO mail-il1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725847AbfLGWD1 (ORCPT ); Sat, 7 Dec 2019 17:03:27 -0500 Received: by mail-il1-f194.google.com with SMTP id z90so9406716ilc.8 for ; Sat, 07 Dec 2019 14:03:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5nppC0dn8qY+mD1E09P6PznSd/Bh4xxBWze2A2WO09Q=; b=IlO3aG3FRZD0xu9tViplgiGfRS37CuKkEj2ScqdH3KZ2Bzcf4tsYAuLrY+OW7xfQnQ Y4MC304D5enhqMluX9wGOBUfm37Pl9zvBr+WVyglzg9SPMpmkcYgp2SnFHdUYwLnO4cX DS7ikHBIbZzG3fH1dX50B8kyiQCeWdjPlBaZc032SH4U7bI5SbHRtXnuR3W2li8k287E 9BVwgTzbdRsqz6dzswTUZXsU4WAFUT+LTebfprvvvhUrJFfFfQsRE55FtVj8K0xhgEeP 9HGnDHVOEBAVzlqhNR8XCTnBLiIIAkwxbeJqD85vR86m07DIl75XL3s1my1wr54vmExX F6og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5nppC0dn8qY+mD1E09P6PznSd/Bh4xxBWze2A2WO09Q=; b=RgxmTPE9CR1sEPxJf6i5k/lZdHk0+W8hcN03sXwanRMtnx1mJnI1Glvrwa1/EotkCP Qm1Fq/mZ4GiRNu08R2ZH5pCGXFFhTIFGXsHDgaXtVpk6zpstVNZLXNbQcxyGAnF6x1gT lIlqKo67j4R4Pji3PHlMlBPOVDEetCichYAqJxbDuGsvhxlfC83y7ZNYmsSOsXDNcdXV bcXUt3Nz9R/ru+sMt4SvTWRnAv446zN1WsbXPv+mo5qI5VmDp0CiqJ4x1TYNwfIXWSW1 TizcXcxUXqWvP0u6udKHNfk9LyZ/QG66xf6R5jmOEC4lN9dyA1osZ4Ls18z7TVZmxPZY pTmQ== X-Gm-Message-State: APjAAAUGz0GJR+cVvdP3VINb7jJfEqxUO0IRn/1vZ+GPI+OFDWKvBgUB JxmlMTo4fzYNm2Qixv2voyLdng== X-Received: by 2002:a92:5805:: with SMTP id m5mr20220506ilb.59.1575756206331; Sat, 07 Dec 2019 14:03:26 -0800 (PST) Received: from google.com ([2620:15c:183:0:209:9736:c663:27c3]) by smtp.gmail.com with ESMTPSA id y11sm5243668ilp.46.2019.12.07.14.03.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Dec 2019 14:03:25 -0800 (PST) Date: Sat, 7 Dec 2019 15:03:20 -0700 From: Yu Zhao To: Christopher Lameter Cc: Andrew Morton , Pekka Enberg , David Rientjes , Joonsoo Kim , "Kirill A . Shutemov" , Tetsuo Handa , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A . Shutemov" Subject: Re: [FIX] slub: Remove kmalloc under list_lock from list_slab_objects() V2 Message-ID: <20191207220320.GA67512@google.com> References: <20191108193958.205102-1-yuzhao@google.com> <20191108193958.205102-2-yuzhao@google.com> <20191109230147.GA75074@google.com> <20191110184721.GA171640@google.com> <20191130150908.06b2646edfa7bdc12a943c25@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 02, 2019 at 03:12:20PM +0000, Christopher Lameter wrote: > On Sat, 30 Nov 2019, Andrew Morton wrote: > > > > Perform the allocation in free_partial() before the list_lock is taken. > > > > No response here? It looks a lot simpler than the originally proposed > > patch? > > Yup. I prefer this one but its my own patch so I cannot Ack this. Hi, there is a pending question from Tetsuo-san. I'd be happy to ack once it's address.