Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2601413ybl; Sat, 7 Dec 2019 19:45:50 -0800 (PST) X-Google-Smtp-Source: APXvYqy6ztPp2J5aIAoFEfrJNmPIiNpgAMVgc/0g11XM4jlOoSNecC8D3rv5xeM3+74KLcl8gaPD X-Received: by 2002:aca:220c:: with SMTP id b12mr18742080oic.55.1575776750232; Sat, 07 Dec 2019 19:45:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575776750; cv=none; d=google.com; s=arc-20160816; b=1HbNp6Xpg+NJWsWX2HWbVU0Ro2D1JyRVmjEAy7FOwkzmSYjFbD8z+qt/bSMDpblFu4 Ya8wOeZHZ8OKOGX+L+weZwzR5buQbAzJo6d1jSPQruKtdDeoldk4VkQOie5trBNt/pmi MoAsufEfqysFhs//Du6mqom9XgHbE1dg9AC0YFBNfZHDOMpBtVFv8JEBKyP5B9VukXdx RVNFyk1pro93ZhdxnhUumSAh8j51+lCbP4YaYsV1j+L+IEdKQ5xbmvWZZk+XDOj66+NP 4YQyVon1GL+vd5CsLmyh2P4Dktecqo1MEqiT/8ZEdZ40odLtzWVG3SLqZx4oP4eXQh5/ Y7uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=lSP8/e8OjiSNZZDmK6SxArGfSuSlNA5shfAilc1iQA0=; b=iICIkaOO1nrDAwvSixsfhIqRw8sf585ue2y7UuN4Ytb2j41kpO81TmxP4RWUhwrecT ZAQP81FXxHbZGg4nmKRPbXOLR6o5Gh5mSgSops7gcIO84jQpZ9iNSx8Azo/pMoq4ImlO ecnakuqrNDGmQYzkk7m18LrSojENCkEBCtEZIsgLP21RKsr6FoCfqxl3FupS8KT/kY24 NFMNSycfBB/38sOA6sfdh/+JeooMe/F8yDVTwNyO5cdPD3ZY+ZZBTGbcezzFqUp0SYjz f/7kFizfl8c75o2cVdHoZn0xOjGgEhClqVXjV+oVueMRzdB/G/8s6VX0V5QMgOZ47ns+ Oxfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l3si10409191otb.319.2019.12.07.19.45.05; Sat, 07 Dec 2019 19:45:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726667AbfLHDmX (ORCPT + 99 others); Sat, 7 Dec 2019 22:42:23 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:56938 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726418AbfLHDmX (ORCPT ); Sat, 7 Dec 2019 22:42:23 -0500 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1idnS4-00084W-CV; Sun, 08 Dec 2019 03:41:47 +0000 Date: Sun, 8 Dec 2019 03:41:44 +0000 From: Al Viro To: Tiezhu Yang Cc: "Theodore Y. Ts'o" , Jaegeuk Kim , Chao Yu , Eric Biggers , Tyler Hicks , linux-fsdevel@vger.kernel.org, ecryptfs@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] fs: introduce is_dot_dotdot helper for cleanup Message-ID: <20191208034144.GP4203@ZenIV.linux.org.uk> References: <1575718548-19017-1-git-send-email-yangtiezhu@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1575718548-19017-1-git-send-email-yangtiezhu@loongson.cn> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 07, 2019 at 07:35:48PM +0800, Tiezhu Yang wrote: > There exists many similar and duplicate codes to check "." and "..", > so introduce is_dot_dotdot helper to make the code more clean. Umm... No objections, in principle, but... you try to say that name (e.g. in a phone conversation) without stuttering ;-/ Any suggestions from native speakers?