Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2971110ybl; Sun, 8 Dec 2019 04:41:03 -0800 (PST) X-Google-Smtp-Source: APXvYqyFpnpCjHEvTy7tiferBVxVpTTJVwZZuD1kaPkOi3ptNZ5IuxARgWQgIW6JVZuUbxdR6svn X-Received: by 2002:aca:2b1a:: with SMTP id i26mr19502577oik.64.1575808863410; Sun, 08 Dec 2019 04:41:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575808863; cv=none; d=google.com; s=arc-20160816; b=PkNSYhScs5nFObhy4pVyc4ge2vujgzbRNYwnu3VMyEySzRH92H6rjXCkkL84zqwT8w xwDY2zR5UKh6hXbABoDKe+hacCIA6HDe+7wazHEit24KvJLcEd8jKtCJ3B0gAYi1KORq N2eQ0MaksAk7nmYkg4UzGUvYgAPuT7Bg05rkyoSJG/XimKEsjShiUu9FW7Q/wIMPROlr Cu+TqXERnsnNwYv/SygepTmM7fs8pKv0QBShgVEeHVHFki2I/3bHTV6GaDEWddQ8s3KW iS2VFU04z/Vvmo+ekvDUd/LoLrZdfbLVHmO4PLcR2+AbBBUD1tckLamZAnq3m2jgp2Ry ivZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2ELcNaQndnrwr3FiX1NwpMEheNcsO2lBa0QVqsnMeCA=; b=zq3n+H49u3q8oyz0WYAj1IXkZt+Ea5eUiSIqKeZ1mf8A603MjVNT5+7NUljbSJTNTO hwf8Zc8VFzGoLoUqNm2rKIQE/jqFaX7bM/FziWVsTkJvg4KIWuxh5tWbEDfmTkneYObZ nqTDwCCQBnCytMITG3YemyEFHPn3c14UWjR0xPcOMvYGDJhMvufKjusgFsxm5MrTnhtd tufbmp3S0zzgWQ24XzAHpyUvNOplojesJgMr7kBJzEnltcKoVxiHzf5/43GpHfZvfR7v HjC3fEe88DYrHYY3pIaoVdmBPk4jZ8BaTtHKjyTBTu7fnWC/C/FgfsvKeorLTCvarP7O 7c0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=U1XvJNbZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i2si9604033otc.130.2019.12.08.04.40.12; Sun, 08 Dec 2019 04:41:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=U1XvJNbZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726440AbfLHMi2 (ORCPT + 99 others); Sun, 8 Dec 2019 07:38:28 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:43270 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726163AbfLHMi2 (ORCPT ); Sun, 8 Dec 2019 07:38:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2ELcNaQndnrwr3FiX1NwpMEheNcsO2lBa0QVqsnMeCA=; b=U1XvJNbZbJPCjOt3AAVxDS0oF Mh4MI6C2RCv9V/mL1VeDkpDKRcIa5JCrtsA48oc1ZWffNGpUIw9aDPdgh/eY/Z/Q4WtyE7XL7R13H aNZLECIv8MGDhMqhxhCqK1oiWpsqzhojIEowfJv2H/LvRalBHVMMUfsS4I77I7ns/h7iIXi4HWqwb GyxnngdRgaYtkRI5xGHMfFDIC8rl7qT9qa1tjyHUshnhjuP/W8K7z2hDCCVU0qUcb7uczdDPfpylS gPg1CQlcwkjyKfXr2gYv2md+i1a3Ba+MfYDEpJDNCATOzq/5SM/3hvEgbW0A9/aYLu+vajeb1GHPp ylpQUn9Uw==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1idvp6-00061v-LN; Sun, 08 Dec 2019 12:38:04 +0000 Date: Sun, 8 Dec 2019 04:38:04 -0800 From: Matthew Wilcox To: Al Viro Cc: Tiezhu Yang , "Theodore Y. Ts'o" , Jaegeuk Kim , Chao Yu , Eric Biggers , Tyler Hicks , linux-fsdevel@vger.kernel.org, ecryptfs@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] fs: introduce is_dot_dotdot helper for cleanup Message-ID: <20191208123804.GB32169@bombadil.infradead.org> References: <1575718548-19017-1-git-send-email-yangtiezhu@loongson.cn> <20191208034144.GP4203@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191208034144.GP4203@ZenIV.linux.org.uk> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 08, 2019 at 03:41:44AM +0000, Al Viro wrote: > On Sat, Dec 07, 2019 at 07:35:48PM +0800, Tiezhu Yang wrote: > > There exists many similar and duplicate codes to check "." and "..", > > so introduce is_dot_dotdot helper to make the code more clean. > > Umm... No objections, in principle, but... you try to say that name > (e.g. in a phone conversation) without stuttering ;-/ > > Any suggestions from native speakers? I used "is_dot_or_dotdot" when discussing this patch with my wife verbally.