Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3568584ybl; Sun, 8 Dec 2019 18:11:35 -0800 (PST) X-Google-Smtp-Source: APXvYqxLp+vt8bmJ+JSLQ4VETjcPH1CHjQ59sO6FAXP2WiXiM8EBLicbq7yqgVwCwgdHAsS02hIP X-Received: by 2002:a54:4086:: with SMTP id i6mr12628981oii.65.1575857495541; Sun, 08 Dec 2019 18:11:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575857495; cv=none; d=google.com; s=arc-20160816; b=A8wkXwcS8SXTieRi13aqLoGYCNV4HiIG4w7i+uTjgbKKbGgVDPruR52EvlhnSsfpsA UCqxF89z3nu1d6aqrk9RQHi7eskB8q7p7JoCVJVMO9jfTzoPg4cp5diO/PMXZWEQCX/Q NGvZgxt+INw2k6t7GSI1wAfYPhSGcHdmsHr7BTqY3hhfhlszJHJ3v6LWKk80RFOffH2D ZzUWuGLGCF9lN34KoQM8q7HU6d5/cT7YvDwyxX6UtAICMxOv3uBDZn4wGRH8nZjONaH3 z1C2hFLwjpwGN5qbPxFwstNFTE8gEzDPu9/QnV35XrLPmB7Zq75+ogra83ZtKsGIeuUh CWDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=53yoUe4jKEPtL9W16njFXW9UBUbhgCp07Y01Zi/VWmE=; b=QOJB8tfu1vj6W0UwqkrGJ1WL2zz59lWbObq6ozgulv9kJ9J+Zc3Lv45vzq2y+NOYy4 IbBPdOrNd3vLWZe+vo78oyFvWaR4i2RFSxdyEm/AKkem9EUDlLFqFH8l7ErqTSQb33QR lDh2wIhPNV15ed45Xc5oosIJgE3vTLlFw/ZbcQSAM/NMuZTgqq4acqgV+6v2YGOAtVuY rRluoU4zrCCpjhb0u1XvsmfKeSDjQFUN2nepYMJA1VDz78564gi/IHowAg7F1MkMuUkf hcv4dSVASfHMwh+Fpb/bUovmiMlKjJypGsKFEpi3wdq5q4r/QbHONiOBHSKuBuZkhkty 02Zg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p28si11204941oth.296.2019.12.08.18.11.21; Sun, 08 Dec 2019 18:11:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726877AbfLICJh (ORCPT + 99 others); Sun, 8 Dec 2019 21:09:37 -0500 Received: from li1843-175.members.linode.com ([172.104.24.175]:57366 "EHLO mail.stoffel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726669AbfLICJh (ORCPT ); Sun, 8 Dec 2019 21:09:37 -0500 X-Greylist: delayed 533 seconds by postgrey-1.27 at vger.kernel.org; Sun, 08 Dec 2019 21:09:36 EST Received: from quad.stoffel.org (66-189-75-104.dhcp.oxfr.ma.charter.com [66.189.75.104]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.stoffel.org (Postfix) with ESMTPSA id 80E521EDDC; Sun, 8 Dec 2019 21:00:42 -0500 (EST) Received: by quad.stoffel.org (Postfix, from userid 1000) id E9A93A5DE1; Sun, 8 Dec 2019 21:00:41 -0500 (EST) Date: Sun, 8 Dec 2019 21:00:41 -0500 From: John Stoffel To: Matthew Wilcox Cc: Al Viro , Tiezhu Yang , "Theodore Y. Ts'o" , Jaegeuk Kim , Chao Yu , Eric Biggers , Tyler Hicks , linux-fsdevel@vger.kernel.org, ecryptfs@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] fs: introduce is_dot_dotdot helper for cleanup Message-ID: <20191209020041.et776tzhxqsqqfs5@quad.stoffel.home> References: <1575718548-19017-1-git-send-email-yangtiezhu@loongson.cn> <20191208034144.GP4203@ZenIV.linux.org.uk> <20191208123804.GB32169@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191208123804.GB32169@bombadil.infradead.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 08, 2019 at 04:38:04AM -0800, Matthew Wilcox wrote: > On Sun, Dec 08, 2019 at 03:41:44AM +0000, Al Viro wrote: > > On Sat, Dec 07, 2019 at 07:35:48PM +0800, Tiezhu Yang wrote: > > > There exists many similar and duplicate codes to check "." and "..", > > > so introduce is_dot_dotdot helper to make the code more clean. > > > > Umm... No objections, in principle, but... you try to say that name > > (e.g. in a phone conversation) without stuttering ;-/ > > > > Any suggestions from native speakers? > > I used "is_dot_or_dotdot" when discussing this patch with my wife verbally. *thumbs up* Both for the wife, and the name. :-) --