Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] devfreq: move declaration of DEVICE_ATTR_RW(min_freq)
To:     Kamil Konieczny <k.konieczny@samsung.com>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>
From:   Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
Message-ID: <c2b9991e-212c-5ba5-a160-36d698e31bee@samsung.com>
Date:   Mon, 9 Dec 2019 12:25:32 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101
        Thunderbird/59.0
MIME-Version: 1.0
In-Reply-To: <20191206101129.15232-1-k.konieczny@samsung.com>
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20191206101145eucas1p26ed05a4d6d805c26c8ad92ad6b602f9d@eucas1p2.samsung.com>
        <20191206101129.15232-1-k.konieczny@samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Kamil,

Looks good to me. Applied it.

On later, better to add 'PM / ' prefix for patch title
and use capital char for first word as following:

devfreq: move declaration of DEVICE_ATTR_RW(min_freq)
-> PM / devfreq: Move declaration of DEVICE_ATTR_RW(min_freq)

On 12/6/19 7:11 PM, Kamil Konieczny wrote:
> Declaration of DEVICE_ATTR_RW(min_freq) is placed after function
> max_freq_store. Move it to the correct place after min_freq_show.
> 
> Signed-off-by: Kamil Konieczny <k.konieczny@samsung.com>
> ---
>  drivers/devfreq/devfreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 1786a86b1779..46a7ff7c2994 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -1368,6 +1368,7 @@ static ssize_t min_freq_show(struct device *dev, struct device_attribute *attr,
>  
>  	return sprintf(buf, "%lu\n", min_freq);
>  }
> +static DEVICE_ATTR_RW(min_freq);
>  
>  static ssize_t max_freq_store(struct device *dev, struct device_attribute *attr,
>  			      const char *buf, size_t count)
> @@ -1391,7 +1392,6 @@ static ssize_t max_freq_store(struct device *dev, struct device_attribute *attr,
>  
>  	return count;
>  }
> -static DEVICE_ATTR_RW(min_freq);
>  
>  static ssize_t max_freq_show(struct device *dev, struct device_attribute *attr,
>  			     char *buf)
> 


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics