Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3614022ybl; Sun, 8 Dec 2019 19:22:30 -0800 (PST) X-Google-Smtp-Source: APXvYqziDbCzpCyZfDzH0MPyRFwWlhlBf2uurBnaWMx8YdlvwQcsGDVBF0e0UFL6cIBv6DUZBC3d X-Received: by 2002:aca:3ed5:: with SMTP id l204mr16102957oia.92.1575861750234; Sun, 08 Dec 2019 19:22:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575861750; cv=none; d=google.com; s=arc-20160816; b=ZUcYxBv2LHOxFi4sopm8nHaT+XUxIH6F5CAuBmx4iGQaoV1aglQflrTV7hHyEKo0uC DbDN9hArnsTlAOSfd0/+d9yyefkJc0uUkC7o5nl/eqhyFbD5q4W5Lgl/izGCoRXCFWwX HYgeXCH3xuCasdOiFow3Pv20qvenqVlhdKKmsNten36wqrwNhrSYVAiXH0TSws2NxJjS fO29i2ePWhlh4wYwri1FnLWCennZpkiF1wyTpruSIBcQ5OwO/o2Qw0oEuARYDRbs1kCB VGHMm5qT+Ulzt29IDx42PThPoPKlK/p5LqJqJ3UDILHLEv6O0c16H2H2sAhDBsd8Q2Tq y1OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from; bh=PwanK54AxpmVs6tpcetfIA9LRvX5hKlLglewOgWBoHE=; b=yMZ2A/kNJQB8ykJdISCbHYbxU/ASbncnYutSKa8PGBVz6R+Hxbn4rfFYZWDbOF2/2D k4UleXq18Sn5ZS8qCvS/Rp2STLDKyJGWTpxq2wq5ozpiwP9W543iszwttWqVUuqEw7aY LxBieQ1cSZHQjljzg4ovZwDaD6ViwnT/ZtzuPjPhQPqV793lzLmD8F9upJGrumu26NhO VA5MDipgeh0CMrFR0GgvQO/Lg7+uLB6PtjVufx3bwHlBu92nkfWf2NCWQK+m9UlIoOpp G2nS4ZZXH9dytXbH7KMpY12nIkfSWKYGMrUTE4RkhY1eK+4ckD3zZhSnU1XFKCaR7X3J +2Zw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d17si2161460otp.315.2019.12.08.19.22.18; Sun, 08 Dec 2019 19:22:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727103AbfLIDU2 (ORCPT + 99 others); Sun, 8 Dec 2019 22:20:28 -0500 Received: from mga14.intel.com ([192.55.52.115]:37235 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727084AbfLIDU1 (ORCPT ); Sun, 8 Dec 2019 22:20:27 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Dec 2019 19:20:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,294,1571727600"; d="scan'208";a="387102974" Received: from sgsxdev004.isng.intel.com (HELO localhost) ([10.226.88.13]) by orsmga005.jf.intel.com with ESMTP; 08 Dec 2019 19:20:23 -0800 From: Dilip Kota To: lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org Cc: jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, andrew.murray@arm.com, robh@kernel.org, linux-kernel@vger.kernel.org, andriy.shevchenko@intel.com, cheol.yong.kim@intel.com, chuanhua.lei@linux.intel.com, qi-ming.wu@intel.com, Dilip Kota Subject: [PATCH v11 3/3] PCI: artpec6: Configure FTS with dwc helper function Date: Mon, 9 Dec 2019 11:20:06 +0800 Message-Id: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use DesignWare helper functions to configure Fast Training Sequence. Drop the respective code in the driver. Signed-off-by: Dilip Kota Signed-off-by: Lorenzo Pieralisi Reviewed-by: Andrew Murray --- drivers/pci/controller/dwc/pcie-artpec6.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-artpec6.c b/drivers/pci/controller/dwc/pcie-artpec6.c index 9e2482bd7b6d..28d5a1095200 100644 --- a/drivers/pci/controller/dwc/pcie-artpec6.c +++ b/drivers/pci/controller/dwc/pcie-artpec6.c @@ -51,9 +51,6 @@ static const struct of_device_id artpec6_pcie_of_match[]; #define ACK_N_FTS_MASK GENMASK(15, 8) #define ACK_N_FTS(x) (((x) << 8) & ACK_N_FTS_MASK) -#define FAST_TRAINING_SEQ_MASK GENMASK(7, 0) -#define FAST_TRAINING_SEQ(x) (((x) << 0) & FAST_TRAINING_SEQ_MASK) - /* ARTPEC-6 specific registers */ #define PCIECFG 0x18 #define PCIECFG_DBG_OEN BIT(24) @@ -313,10 +310,7 @@ static void artpec6_pcie_set_nfts(struct artpec6_pcie *artpec6_pcie) * Set the Number of Fast Training Sequences that the core * advertises as its N_FTS during Gen2 or Gen3 link training. */ - val = dw_pcie_readl_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL); - val &= ~FAST_TRAINING_SEQ_MASK; - val |= FAST_TRAINING_SEQ(180); - dw_pcie_writel_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL, val); + dw_pcie_link_set_n_fts(pci, 180); } static void artpec6_pcie_assert_core_reset(struct artpec6_pcie *artpec6_pcie) -- 2.11.0