Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3855984ybl; Mon, 9 Dec 2019 00:59:13 -0800 (PST) X-Google-Smtp-Source: APXvYqyBc3VzSsly+go79Z0NmmoCNCUFlicXkQZF4SnAbu2bot5cY+Gfqx5QChkfJ9YS+X2Gvlsp X-Received: by 2002:a05:6808:1c6:: with SMTP id x6mr17863914oic.49.1575881953427; Mon, 09 Dec 2019 00:59:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575881953; cv=none; d=google.com; s=arc-20160816; b=O/S869XoV3Zq3xQwnFXtcV42PNQ03aIxEr9S2ps+8E8Vx75xugqimjyRMNK3GXij2J krCyRIhEcNhfbQD8yu2j3zOa9ckm4T6eitSO4eUDDp+pBAFtT0oWJw5MIIyGeawfEARl 9sdFFL7i68RCnhqwqjWlkIaBK/jWE02JM1jCItwPAN96lPJMm16fTiNasq2d6B36wkkR pj184nvL/7kfbHa1qjXbg2fAUMnJF0GaPfM7B47Rf6ZVfKVYf8Uk9jk4Qx5BtqdIEUEH qaqLfhe/CLjpJ/xElbx4ZFHWdU99j9Oo0RB6G/AmwviW5mpGoO97R503w3E4LAzZEcqA mspA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=wJ5N7Jirljd8jLW/XZ0r9Y6/RYhfpOU7K02lJrm8fcM=; b=VHgwNYUqtiGeuR4YA6QnWiu4M1nBYQsPvJ07BupPw6s5TKeI+yEX/4KlJzloGCs6Ht gcNwowYqedB3N/NDEY+SJ2GYdhZZt58euVVI/Vhn73GBNggAe4hBQHCFRWlP7Sg2rL8A N3cJmAEh7dF9j+JPJFF2qAs/oXEdySbWAu7gmj3XSDqJh+ksjTlcQ5daFghPHaRheuL1 Ii150JBHPEhkGMJlJ4uvVBxGXwiViDa6tcwaWBsFrRp2/W6IQ8vZQ+LDMrLcRVKI4D1G aUGJq+qD7l+qBWwGVevsuvQOno1UCbx0kS0yyLW9OfqW3m8KkSWpP9Y/s3BLr7POgVIa MgCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=hyTu6197; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o8si12384555oti.47.2019.12.09.00.59.01; Mon, 09 Dec 2019 00:59:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=hyTu6197; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727322AbfLII57 (ORCPT + 99 others); Mon, 9 Dec 2019 03:57:59 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:37141 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726377AbfLII57 (ORCPT ); Mon, 9 Dec 2019 03:57:59 -0500 Received: by mail-pf1-f196.google.com with SMTP id s18so6872599pfm.4 for ; Mon, 09 Dec 2019 00:57:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wJ5N7Jirljd8jLW/XZ0r9Y6/RYhfpOU7K02lJrm8fcM=; b=hyTu61975irxP9bn3UGpHOHL7Qkqq2SiDtYV1LljIZxPR4gjdO3lptLg+X/x+wliZH BTJQzbrVJVz4CPFBoTH9tiSABZP0AlTPHR/CeOFh4gJbHRaGrFcpj/a9g5tUVCY8eBa7 ZMPetM3GCqq86RyqQINuYvmXgs5QsApn6Wnly7dRViLvYYhZ0s9jZGOKYylPiZBf0ecA jWzM9moE/+x5LC3WPSap+UFuO7FjcLm3Ic8mplwUZ3J9XGmunxAKzRsigc62QIb1V9Pz y4pUa4wKyQ6Fw6Uel00Qnr03YCGa57TfCGk4aoHrSh4NlBvzNt3ndGZP1OQRocZBrfNy i/Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wJ5N7Jirljd8jLW/XZ0r9Y6/RYhfpOU7K02lJrm8fcM=; b=exiEbN5OqYRVH1HW+EAi6xf6tHrDD97F9H3Gg9Zb+GQgoWbRaZ+eJr1LCeoCzxj8Ce iJof/DafjiqmV8goxY+L+1SAX886NDIKIpJQA+sp2yx/oj++uG4hbjqA0uTdNjzKVDuX wvyEKkDNN+smSXdzmB4j5GBy3zhx2acEJMl9fAzCGFmUFCLu7aopgv/ie/5s/8szgzUt dTIZz7oh1rn69Lx3ARkCAsFGOzHRYQNvZx8APGSwLLSK3eM8ciqdR2D8RXb5RXklNKtd uegNsDKXslb2qiAifLiVTuilXWYM78bPXZTIec74hRSJJ9RL4n3Fb2jK7Sgm9bpyOsCX TQfA== X-Gm-Message-State: APjAAAVcuKzX26Wx2lR4gsqbvsTT5JLiwdxCfXvZcKos/j1TfMpH+3U/ 0vmsntFL1VBOlfWWV9jU8PI= X-Received: by 2002:aa7:961b:: with SMTP id q27mr28498150pfg.23.1575881879038; Mon, 09 Dec 2019 00:57:59 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id o17sm3474228pjq.1.2019.12.09.00.57.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2019 00:57:58 -0800 (PST) From: Chuhong Yuan Cc: Patrik Jakobsson , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH] drm/gma500: add a missed gma_power_end in error path Date: Mon, 9 Dec 2019 16:57:47 +0800 Message-Id: <20191209085747.16057-1-hslester96@gmail.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org oaktrail_lvds_mode_set() misses a gma_power_end() in an error path. Add the call to fix it. Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/gma500/oaktrail_lvds.c b/drivers/gpu/drm/gma500/oaktrail_lvds.c index 7390403ea1b7..582e09597500 100644 --- a/drivers/gpu/drm/gma500/oaktrail_lvds.c +++ b/drivers/gpu/drm/gma500/oaktrail_lvds.c @@ -117,6 +117,7 @@ static void oaktrail_lvds_mode_set(struct drm_encoder *encoder, if (!connector) { DRM_ERROR("Couldn't find connector when setting mode"); + gma_power_end(dev); return; } -- 2.24.0