Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3879015ybl; Mon, 9 Dec 2019 01:28:07 -0800 (PST) X-Google-Smtp-Source: APXvYqyWhMWJbM0ObU3i5NoyCNeqoeaZNJeHqFpFJkUOPfdQafVfRk+EAy1psOpGblPxCcvgYkDo X-Received: by 2002:aca:5cc1:: with SMTP id q184mr20391919oib.122.1575883687606; Mon, 09 Dec 2019 01:28:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575883687; cv=none; d=google.com; s=arc-20160816; b=ndAjmMmetkkTUCYntWwjqd0AG7bHjcBnmcQA+BFjbLJI6DvE6/iKASKgMnxR+g+mm5 MO2aRnkGhZ4OK1KUC9c/vLOB5ZtvejkxNRlMJDuJixlEjbQmQby2kPWDX2m1m8R+64VL MwYloy6T7aLA7snxSFhzX31iqnRNfe2I7DKzToJN/IFj6U32rR/A5/xF5Z+KUpNeug2N nQEvcp2HhlVyV+ubIoQEExvl0vYnc7+aZlY2AoJRJw5XxhvGwyl80G7bMQN6meg+HqyF BKD/0XeZaE1EbDRNfWnRkEcVbRpJKIvHsIWx/+GszBygkHeF2I4G8350Z3AZNHlGWMVD k2pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=J5879LZ/Pi63QwYbKH9FG7q4Bl0Ds4fjn/Pvg7Od1Ec=; b=vOrcCJUFbPCpbGR/XyM/uADtGqXZ+Y6yYO32YKchb3pgPPdpNFBizxCSlaUT52P60x PizM++NA3ESDIRkRPtMVkxe7PX61qvdnTne1lsHsuXVl8Nzdm34zJaUr6V0xtA/DNMCF TVe0+EpTDfuSsObuptyM7yLSPSI6CujfcbHEHxo+X/PTvtoWvPHEwXsSy9Lct6fS/SpH rWqWiD8dzVH69UZXa6T97kwFlHv1oY7ORkfLPm9YagkUCVb2ZdBb8pjxB0bKJShNQ0e8 xTvo5ScugOiFHETgwNYcEj3ZJcwhSRbd+sgot1SBfJHZc38/0E2i2fi1qhPmu3VZDLJy UcOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=RZaX0ioq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o6si6304963otk.201.2019.12.09.01.27.55; Mon, 09 Dec 2019 01:28:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=RZaX0ioq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727359AbfLII6p (ORCPT + 99 others); Mon, 9 Dec 2019 03:58:45 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:35062 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726377AbfLII6o (ORCPT ); Mon, 9 Dec 2019 03:58:44 -0500 Received: by mail-pf1-f194.google.com with SMTP id b19so6881883pfo.2; Mon, 09 Dec 2019 00:58:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=J5879LZ/Pi63QwYbKH9FG7q4Bl0Ds4fjn/Pvg7Od1Ec=; b=RZaX0ioqUEqw0QfmHP6faFSw/t94WFmFghK9AEN6Yv+N/+UKM772AHLpfMdRLslZCz A1LJv9UNjP5cXmhnRr/SWM/veawKnW1O+iElSUa5ANIA9akzRPw9A9t+sr4xuTp1CnLW 2QueHSGHz/xh0Mpg5C31KZN2D/Uyu1LKQGTzO5S1a+AUG1Ky+qPl3uhZrOB1i+QBEEfV hSI2mvJvTb1hQga8wCfn6zUhQpldlomq2PprONFxrzqDnyb58T+3YlJ0Rk+HInqAqvor QkjLVHbIAEPN5qD75BlwVNmISorFFWMfXJvZfx0Tm0GEN5OmLmpcdGrqnt/LAq1VDAqb isTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=J5879LZ/Pi63QwYbKH9FG7q4Bl0Ds4fjn/Pvg7Od1Ec=; b=hp/sW0T0wG9qNqBAjZrNghNzf3d9IMbrJxvXtPRMXs3t4y6Ylj9KPxM1GnUKTiE9sG KcCpKwjLKaF/I35+KgGiCg6VLNlN3Lhqd0Icub5MvpKhKb8gQXor5va7QTkBmsoDkXB/ hT4T8bUXMa8SsqaWHgghRRmj/6/9h84WRrZ4boy02hie9W/9UnjmxGcAFiQfvBLGBt2z WzIiv0/PN4ntEtGX90xnllBe1PH7xd8LwfBo9lba8GjDrpe1L03J9x3qHPwY7ungd1yA a56o7HzoTSdLAF0i9tWp8RjH6qBD7gsPB9kuPiszrW/aodPwNNIWJMeCXxp6KZ7PUxfw PSGg== X-Gm-Message-State: APjAAAU27iI95TRG7F5i130hJF9e2tj3rftJDamzSLGN5OWAlaO0lqZI TrYAs+eUv6Qk3zdRxrrXGIE= X-Received: by 2002:a63:cc02:: with SMTP id x2mr17928600pgf.114.1575881923958; Mon, 09 Dec 2019 00:58:43 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id f24sm11681569pjp.12.2019.12.09.00.58.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2019 00:58:43 -0800 (PST) From: Chuhong Yuan Cc: Rui Miguel Silva , Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH] media: imx7-mipi-csis: Add the missed v4l2_async_notifier_cleanup in remove Date: Mon, 9 Dec 2019 16:58:28 +0800 Message-Id: <20191209085828.16183-1-hslester96@gmail.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All drivers in imx call v4l2_async_notifier_cleanup() after unregistering the notifier except this driver. This should be a miss and we need to add the call to fix it. Signed-off-by: Chuhong Yuan --- drivers/staging/media/imx/imx7-mipi-csis.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c index 99166afca071..2bfa85bb84e7 100644 --- a/drivers/staging/media/imx/imx7-mipi-csis.c +++ b/drivers/staging/media/imx/imx7-mipi-csis.c @@ -1105,6 +1105,7 @@ static int mipi_csis_remove(struct platform_device *pdev) mipi_csis_debugfs_exit(state); v4l2_async_unregister_subdev(&state->mipi_sd); v4l2_async_notifier_unregister(&state->subdev_notifier); + v4l2_async_notifier_cleanup(&state->subdev_notifier); pm_runtime_disable(&pdev->dev); mipi_csis_pm_suspend(&pdev->dev, true); -- 2.24.0