Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 9 Dec 2019 17:08:42 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Michael Walle <michael@walle.cc>, Alison Wang <alison.wang@nxp.com>
Cc:     linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Li Yang <leoyang.li@nxp.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] arm64: dts: ls1028a: put SAIs into async mode
Message-ID: <20191209090840.GL3365@dragon>
References: <20191129210937.26808-1-michael@walle.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191129210937.26808-1-michael@walle.cc>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

+ Alison Wang

On Fri, Nov 29, 2019 at 10:09:37PM +0100, Michael Walle wrote:
> The LS1028A SoC has only unidirectional SAIs. Therefore, it doesn't make
> sense to have the RX and TX part synchronous. Even worse, the RX part
> wont work out of the box because by default it is configured as
> synchronous to the TX part. And as said before, the pinmux of the SoC
> can only be configured to route either the RX or the TX signals to the
> SAI but never both at the same time. Thus configure the asynchronous
> mode by default.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>

Alison, Leo,

Looks good to you?

Shawn

> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 379913756e90..9be33426e5ce 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -637,6 +637,7 @@
>  			dma-names = "tx", "rx";
>  			dmas = <&edma0 1 4>,
>  			       <&edma0 1 3>;
> +			fsl,sai-asynchronous;
>  			status = "disabled";
>  		};
>  
> @@ -651,6 +652,7 @@
>  			dma-names = "tx", "rx";
>  			dmas = <&edma0 1 6>,
>  			       <&edma0 1 5>;
> +			fsl,sai-asynchronous;
>  			status = "disabled";
>  		};
>  
> @@ -665,6 +667,7 @@
>  			dma-names = "tx", "rx";
>  			dmas = <&edma0 1 8>,
>  			       <&edma0 1 7>;
> +			fsl,sai-asynchronous;
>  			status = "disabled";
>  		};
>  
> @@ -679,6 +682,7 @@
>  			dma-names = "tx", "rx";
>  			dmas = <&edma0 1 10>,
>  			       <&edma0 1 9>;
> +			fsl,sai-asynchronous;
>  			status = "disabled";
>  		};
>  
> @@ -693,6 +697,7 @@
>  			dma-names = "tx", "rx";
>  			dmas = <&edma0 1 12>,
>  			       <&edma0 1 11>;
> +			fsl,sai-asynchronous;
>  			status = "disabled";
>  		};
>  
> @@ -707,6 +712,7 @@
>  			dma-names = "tx", "rx";
>  			dmas = <&edma0 1 14>,
>  			       <&edma0 1 13>;
> +			fsl,sai-asynchronous;
>  			status = "disabled";
>  		};
>  
> -- 
> 2.20.1
>