Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191116151308.17817-1-hslester96@gmail.com> <20191209090020.GG3468@dell>
In-Reply-To: <20191209090020.GG3468@dell>
From:   Chuhong Yuan <hslester96@gmail.com>
Date:   Mon, 9 Dec 2019 17:09:01 +0800
Message-ID: <CANhBUQ2+ogNxA7OGM87igDrCSfbhvCzV5HEzQUWgDqwuMHBE3Q@mail.gmail.com>
Subject: Re: [PATCH] mfd: sm501: fix mismatches of request_mem_region
To:     Lee Jones <lee.jones@linaro.org>
Cc:     LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Dec 9, 2019 at 5:00 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Sat, 16 Nov 2019, Chuhong Yuan wrote:
>
> > This driver misuses release_resource + kfree to match request_mem_regio=
n,
> > which is incorrect.
> > The right way is to use release_mem_region.
> > Replace the mismatched calls with the right ones to fix it.
> >
> > Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> > ---
> >  drivers/mfd/sm501.c | 19 +++++++------------
> >  1 file changed, 7 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> > index 154270f8d8d7..e49787e6bb93 100644
> > --- a/drivers/mfd/sm501.c
> > +++ b/drivers/mfd/sm501.c
> > @@ -1086,8 +1086,7 @@ static int sm501_register_gpio(struct sm501_devda=
ta *sm)
> >       iounmap(gpio->regs);
> >
> >   err_claimed:
> > -     release_resource(gpio->regs_res);
> > -     kfree(gpio->regs_res);
> > +     release_mem_region(iobase, 0x20);
> >
> >       return ret;
> >  }
> > @@ -1095,6 +1094,7 @@ static int sm501_register_gpio(struct sm501_devda=
ta *sm)
> >  static void sm501_gpio_remove(struct sm501_devdata *sm)
> >  {
> >       struct sm501_gpio *gpio =3D &sm->gpio;
> > +     resource_size_t iobase =3D sm->io_res->start + SM501_GPIO;
>
> Shouldn't this be 'struct resource *'?
>

sm501_register_gpio() uses resource_size_t, so I use the same type in remov=
e.

> --
> Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF]
> Linaro Services Technical Lead
> Linaro.org =E2=94=82 Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog